Variable tab widget #4906
Variable tab widget #4906
Conversation
Make InstrumentTrackWindow as large as the InstrumentView requires
Previously, they had been resized by the fixed size parent tab widget. We need to do this manually now.
- Fix the instrument window tabs minimum width and height formulae - Also set minimum height and width for instrument tab
|
This may be the most difficult Lv2 sidebranch concerning regression (i.e. other ). It would be really cool if someone can review, otherwise I'll need to merge this without review in 7 days. |
JohannesLorenz
added
gui
needs code review
There was a problem hiding this comment.
Finished review and found only few coding convention issues otherwise code look good. 👍
Also tried the branch and noticed that the 'orange stripe' bug mentioned in #4899 is present here. I think it's the background that is repeating and the widget showing it is 1px to height.
JohannesLorenz
removed
needs code review
In the instrument plugin tab, there was an orange stripe for TripleOscillator. This was because internally, TabWidget moves up the widget by 1 (TabWidget.cpp, line 89). The size of the whole window is: ``` widget->height() + m_tabbarHeight - 1 ``` So this code adds an offset of "-1" to the necessary computations.
|
First of all, many thanks for the review! I fixed everything, any stripes (like the orange one for 3osc) should be gone now. I'll do a regular merge when you're OK. |
Awesome! Yes I'm happy with the code 👍 |
|
From #4899:
Isn't this related to this PR? It means this PR doesn't break anything for now since we don't use this feature right now, but there are some issues with the code. |
|
@PhysSong Unfortunately that's true. The code will not break anything, but will have this UI issue. I tried to fix it, but I really did not understand it. For now, I think Lv2 is more urgent than fixing that minor UI bug. |
This adds a boolean to the tab widget to specify whether it should be resizable. As a consequence, the Instrument Window will resize to fit its contents.