Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes removing controller in controller rack bug #200

Merged
merged 3 commits into from
Jan 30, 2014

Conversation

SadaleNet
Copy link
Contributor

Fixes #28
Changes:

  • Show confirm message when a controller being deleted is associated.
  • When peak controller is deleted, its fx is also deleted.
    Hopefully I won't introduce new bug.

However, if you remove the Controller, the FX will not be destroyed becaues there is currently no way to destroy the FX without knowing where the view is.

It seems that I've proven this guy was wrong. :P

@tobydox
Copy link
Member

tobydox commented Jan 30, 2014

Almost perfect :-) Can you please rename "getEffectChain()" to "effectChain()" only?

@SadaleNet
Copy link
Contributor Author

@tobydox no problem. Hold on and wait for my edit.
EDIT: done.

tobydox added a commit that referenced this pull request Jan 30, 2014
Fixes removing controller in controller rack bug
@tobydox tobydox merged commit 9f6b894 into LMMS:stable-0.4 Jan 30, 2014
@SadaleNet SadaleNet deleted the issue28 branch January 31, 2014 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants