Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to remove a LFO controller #28

Closed
eagles051387 opened this issue Jan 15, 2014 · 1 comment
Closed

Impossible to remove a LFO controller #28

eagles051387 opened this issue Jan 15, 2014 · 1 comment
Assignees
Labels

Comments

@eagles051387
Copy link

I would propose to permit the removing of a LFO controller if it's not connected to any control. If it's connected, a dialog should ask a confirmation to the user to unconnect all controls driven by this controller before removing it.

Paul Giblock: Oops sorry. Forgot to close the issue. This should be resolved.

Paul Giblock: Reopened. The reason this wasn't Closed is because we need to make Peak Controller delete properly.

Tobias Doerffel: What about it? Is it fixed now?

Paul Giblock: No, it isn't fixed. You can remove the FX, then the controller will auto-destroy.
However, if you remove the Controller, the FX will not be destroyed becaues there is currently no way to destroy the FX without knowing where the view is. This goes back to the whole problem of LMMS's classes still being highly View dependent, even after the MV changes.
Any implementation suggestions?

@ghost ghost assigned pgiblock Jan 15, 2014
@SadaleNet
Copy link
Contributor

I am working on it. Almost finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants