-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High-dpi / high-resolution support, GUI scaling #455
Comments
Vesa in regards to scaling I think you are making it really complex for On Fri, Mar 14, 2014 at 8:50 AM, Vesa V notifications@github.com wrote:
Jonathan Aquilina |
On 03/14/2014 09:54 AM, eagles051387 wrote:
What exactly is really complex? The problem with detecting screen resolution is that the DPI doesn't No, it's better to let the user set the scaling factor. It's not a big |
Here is another thing to pick your brain. What if a user with a dual On Fri, Mar 14, 2014 at 9:21 AM, Vesa V notifications@github.com wrote:
Jonathan Aquilina |
On 03/14/2014 10:42 AM, eagles051387 wrote:
Well then that user is likely facing a lot of other problems as well. That's a pretty narrow corner case though, most people with In any case it's still better to let the user choose the scaling factor, |
I think a multi multi window mode should be setup in lmms. Then again isn't On Fri, Mar 14, 2014 at 9:53 AM, Vesa V notifications@github.com wrote:
Jonathan Aquilina |
On 03/14/2014 10:58 AM, eagles051387 wrote:
Ok sure but that's getting a bit off topic here. Maybe this should be |
It would be cool with high res icons and great if you could decide for yourself exactly how big you want them. I am really wondering if it is necessary to manually edit all the graphics to take the scaling factor in account... Someone could probably make a program for that ❓ |
On 03/14/2014 04:08 PM, Stian Jørgensrud wrote:
Stian, if we were capable of making programs that are that good at There are some pretty neat scaling algos, but they're not perfect and |
I didn't meant auto scaling the pictures into higher res, which is impossible I think. I meant that adding editing the code manually could probably be done automatically. Isn't it just searching for specific words and then add the new lines of code? |
On 03/14/2014 10:40 PM, Stian Jørgensrud wrote:
Not impossible, just not necessarily very good quality. Although, to be
Well no, we can't edit the code automatically, it needs to be done by |
regarding multi-mon it would be maybe an idea that you can manually type in the overal screen resolution. JustMy2Cents regards, |
That is usually handled by the OS. On windows at the os level you tell it On Mon, Mar 17, 2014 at 12:24 PM, boulder74 notifications@github.comwrote:
Jonathan Aquilina |
on starting an application you can hand over the resolution to the GUI too... that was the idea mentioned in my previous email. |
Just for reference: Apple's work-around for their high DPI "retina" display is to provide assets at 1x and 2x resolutions. Regarding multiple monitors with "low" and "high" resolutions: a window only exists on one display at a time. |
On 03/18/2014 03:49 PM, Paul Giblock wrote:
Well not necessarily, some people may want to stretch their LMMS window Although, in those cases people usually use monitors with similar |
I'm kind of rethinking the necessity of this. It seems that most modern desktop environments are already implementing HiDPI support on the OS level, which would make any application support somewhat redundant. Of course, it could still be nice to have as it would mean better visual quality in HiDPI systems. But I think this is probably not going to be a priority at least in the near future. |
I think one platform we can test this on is ubuntu to see how well its On Sun, Mar 30, 2014 at 3:29 AM, Vesa V notifications@github.com wrote:
Jonathan Aquilina |
I hear Qt 5 is getting HiDPI support on the toolkit level, so for now, I'm thinking we should just wait until the time comes to migrate to Qt5, and when that happens we'll get HiDPI support "for free". I don't think it makes much sense to implement application-wide HiDPI support only to have it replaced later on by Qt's solution. Until that, people with HiDPI screens can just use the OS/DE scaling capabilities... |
The font issues are mostly a duplicate of #455. Issue #455 has specific files that can be fixed right now to help support better font scaling and is a place people can help right away. The Qt5 "HiDPI" stuff is as described a "free" benefit from switching from Qt4 to Qt5, so that is mostly addressed here #2108. The rest (svg support, etc) will come with time through long-term work with theme updates such as #1839, #880, #1911. Closing for now, but please feel free to reference or reopen at a later time. |
This is again something that has been discussed in mailing lists which I'm posting here so that it exists in the issue tracker. This is all post-1.0.0 stuff and in no hurry to get implemented, though.
High-dpi screens are getting more common, and this presents a challenge to applications to function in diverse resolutions. Some desktop environments provide the option to automatically scale the GUI of applications, but it would be even better if the application does it themselves, or provides the option for the user to set the scaling factor.
I'm thinking the latter would be the best choice here, since it would also benefit people with impaired vision to be able to scale up the GUI.
So this would require two steps:
This would also mean we should implement support for .svg in the pixmap embedding code. But that doesn't mean everything should be in .svg - we should use it where it makes sense and not compromise on visual style. I'm thinking a smart way to do this would be to modify embed.cpp so that when it's given a request to search for eg. "add_automation", instead of just searching for "add_automation.png" it will first search for .svg, if that isn't found, it searches for a png.
For the latter part, I'm thinking we can provide two versions of every png image: normal and 2x size. The way it would work is, in regular 1x scale, the regular "automation.png" would be used, but if the scaling factor is >1, then it would search for "automation.x2.png" and scale it down according to the scaling factor. This is because with bitmaps, scaling down is always cleaner than scaling up.
Most of the current UI elements already have either a .svg version or a 2x size png, which is good. But some don't. For the future, I'd like to request that all graphics contributions should either provide a .svg, or both 1x and 2x sized versions of a png. I've tried to ask this before but I haven't really enforced it as a rule - we should probably take a more strict approach to it in the future.
The text was updated successfully, but these errors were encountered: