Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC - FX Mixer Vertical Height #1185

Closed
Spekular opened this issue Oct 2, 2014 · 14 comments
Closed

RC - FX Mixer Vertical Height #1185

Spekular opened this issue Oct 2, 2014 · 14 comments

Comments

@Spekular
Copy link
Member

Spekular commented Oct 2, 2014

The FX mixer is now large enough vertically to cause LMMS to start with a scrollbar, and the extra space seems to be unused:
fx mixer
(Notice the odd space above the track number, and the huge plus bar)

@Spekular
Copy link
Member Author

Spekular commented Oct 2, 2014

@tresf the second issue still stands. I'll edit post and title.

@Spekular Spekular changed the title RC GUI Issues RC - FX Mixer Vertical Height Oct 2, 2014
@Spekular
Copy link
Member Author

Spekular commented Oct 2, 2014

@tresf, ah ok.

@tresf tresf reopened this Oct 2, 2014
@Umcaruje
Copy link
Member

Umcaruje commented Oct 2, 2014

@Spekular the 'huge' space above the track number is there for a reason. When you Send audio to another channel, a knob appears to declare the amount of audio sent.

@Spekular
Copy link
Member Author

Spekular commented Oct 2, 2014

Ah right, forgot that. It still needs to be fixed somehow imo, since the
scrollbar being there when you launch looks kinda bad and the plus bar is
still huge.
On Oct 2, 2014 4:25 PM, "Umcaruje" notifications@github.com wrote:

@Spekular the 'huge' space above the t

@Spekular https://github.com/Spekular the 'huge' space above the track
number is there for a reason. When you Send audio to another channel, a
knob appears to declare the amount of audio sent.


Reply to this email directly or view it on GitHub
#1185 (comment).

@tresf
Copy link
Member

tresf commented Oct 2, 2014

It still needs to be fixed somehow imo

With all due respect, we have hundreds of these issues that need to be fixed. This one is minor and not really on anyone's radar so opening more bug reports will continue to bury the ones that really do need fixing. What we really need is more developers to help with this stuff and close out bugs. 📻

@dednikko
Copy link

dednikko commented Oct 2, 2014

Well, if I programming learn a language to help, why should I learn? Is
this all c++?
On Oct 2, 2014 9:30 AM, "Spekular" notifications@github.com wrote:

Ah right, forgot that. It still needs to be fixed somehow imo, since the
scrollbar being there when you launch looks kinda bad and the plus bar is
still huge.
On Oct 2, 2014 4:25 PM, "Umcaruje" notifications@github.com wrote:

@Spekular the 'huge' space above the t

@Spekular https://github.com/Spekular the 'huge' space above the
track
number is there for a reason. When you Send audio to another channel, a
knob appears to declare the amount of audio sent.


Reply to this email directly or view it on GitHub
#1185 (comment).


Reply to this email directly or view it on GitHub
#1185 (comment).

@Spekular
Copy link
Member Author

Spekular commented Oct 2, 2014

@tresf I realize this, but as I am currently learning java (my first programming language), and in school, I'm not really able to help with coding. I still want to contribute to development though and that's why I'm submitting issues, art, and grammar fixes. When I say needs to be fixed, I mean at some point in time, and I'm basing that on the fact that this is a regression (once again, this is imo) and that I don't think it shpuld be all too hard to fix (relatively

@tresf
Copy link
Member

tresf commented Oct 2, 2014

I'm not really able to help with coding

@Spekular I'd argue a programming student is one of our best candidates to help with coding.

I am currently learning java (my first programming language)

@Spekular This is the language I code in as well.

don't think it shpuld be all too hard to fix (relatively)

@Spekular Most bugs aren't that hard to fix, but we need more people looking at the code and trying new ideas. C++ isn't hard, but it can be a lot of work since it requires compilation (Java pretends to be compiled, but actually is crunched down to interpreted bytecode just-in-time, allowing you to see results almost immediately. Java also has mature layout managers which make stuff like arranging buttons and overflowing panels tremendously easy). C++ isn't necessarily as quick to get changed. It requires much more competence when creating and destroying stuff. Furthermore, most of our GUI has hard-coded layout elements which make nudging and bumping things around more manual of a process.

Well, if I programming learn a language to help, why should I learn? Is this all c++?

@dednikko For the most part, yes, C++. It uses a lot of C as well (you can mix them interchangeably). There are some items which are in different languages, but generally speaking, QT GUI libraries with C++.

@Spekular
Copy link
Member Author

Spekular commented Oct 2, 2014

@tresf unfortunately, in school + learning java =/= programming student. Programming is a side project/hobby, whereas school is a must (programming isn't even offered at the school/level I'm at). I though LMMS was C++, which I don't know, and I don't want to stop learning java when I've gotten as far as I have (it's taken tons of time), or juggle learning TWO languages in addition to school. This is all in addition to other hobbies like 3D modelling and music production

@Spekular
Copy link
Member Author

Spekular commented Oct 2, 2014

@tresf I'm just starting with GUIs in java and learning CPP at the same time would slow both languages to a crawl. I'd rather get to a point in java where I can create useful applications than be a beginner at two programs. (sorry for multiple comments and errors, on a worse phone than usual)

@tresf
Copy link
Member

tresf commented Oct 2, 2014

Furthermore, I still think this bug report is invalid unless you have a proposal for not showing the scroll bar. From what I can see, in previous versions of LMMS (with less features) the entire DAW could fit on your screen, but with the addition of the new FX mixer, the scrollbar appears.

This is a classic case of new functionality requires more resources. In the case of your bug report, the resource needed is vertical screen real-estate (which tends to increase with time).

Unless you have a valid proposal for fixing the mixer window, this bug is invalid. A scrollbar appearing is not a bug and the mixer's vertical height is at a very reasonable size given the amount of functionality that Vesa has added to it.

I'd actually prefer to mark it as a duplicate of #387 and close this out completely.

@Spekular
Copy link
Member Author

Spekular commented Oct 2, 2014

@tresf go ahead

@tresf
Copy link
Member

tresf commented Oct 2, 2014

Marking as duplicate of #387.

@Spekular, P.S. don't underestimate your ability to learn two things at once. C++ makes Java a cakewalk.

@tresf tresf closed this as completed Oct 2, 2014
@tresf tresf added the duplicate label Oct 2, 2014
@diizy
Copy link
Contributor

diizy commented Oct 2, 2014

On 10/02/2014 05:30 PM, Spekular wrote:

Ah right, forgot that. It still needs to be fixed somehow imo, since the
scrollbar being there when you launch looks kinda bad and the plus bar is
still huge.

The plus button is huge because there's no other buttons in the mixer.
It'd be pointless to make it smaller because we don't have anything to
use that space for yet. If/when we add more buttons in the future, then
the layout will be adjusted.

As for there being a scrollbar at startup, that's of course entirely
dependent on your screen size. Of course, if your monitor resolution is
too small to show all LMMS windows in whole, there will be a scrollbar.
There's no way around this.

What I hope we can do in the future is allow users to save and load
window layouts, and set one as default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants