fix(tslib): standarised to use private _ over # to prevent: #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansonhkg
changed the title
4 tasks
FedericoAmura
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
There is one more # call in DiscordProvider
Then our sdk would be #-calls free =D
joshLong145
reviewed
Jul 10, 2024
| @@ -2,6 +2,11 @@ | |||
| # yarn lockfile v1 | |||
|
|
|||
|
|
|||
| "@aashutoshrathi/word-wrap@^1.2.3": | |||
There was a problem hiding this comment.
Is there a reason we need to update the lock with this pr? I dont see any changes to our package.json so just curious.
There was a problem hiding this comment.
package.json file is updated in the master branch but the yarn.lock is old, and i checkout -b from master that's why yarn.lock is added here.
Ansonhkg
deleted the
feature/lit-3139-identify-private-methods-in-litnodeclient-fix-tslib-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for this:
#495