Skip to content

fix(tslib): standarised to use private _ over # to prevent: #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Jun 4, 2024

Description

Replace private methods #methodFoo to private _methodFoo

This is a fix for this:

Related PRs:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Published 6.0.0-testing.7 to test on this repo:
https://github.com/LIT-Protocol/developer-guides-code/tree/master/custom-auth/browser

@Ansonhkg Ansonhkg marked this pull request as ready for review June 4, 2024 18:09
@Ansonhkg Ansonhkg requested a review from joshLong145 as a code owner June 4, 2024 18:09
@Ansonhkg Ansonhkg requested a review from MaximusHaximus June 4, 2024 18:16
@joshLong145
Copy link

@Ansonhkg
Wanna update this and we can merge it? Quite a nice cleanup ❤️

@Ansonhkg
Copy link
Collaborator Author

moving this PR to #526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants