Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop → master merge for v1.4.1 #682

Merged
merged 79 commits into from
Oct 14, 2022
Merged

Develop → master merge for v1.4.1 #682

merged 79 commits into from
Oct 14, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Oct 14, 2022

No description provided.

stelmo and others added 30 commits August 5, 2022 10:15
triggered by @stelmo on PR #661
Finally add DocStringExtensions 🥳
triggered by @stelmo on PR #654
Fix pFBA issue with return type nothing
add an explanation of what happens when you gapfill a feasible model
stelmo and others added 23 commits September 3, 2022 15:17
triggered by @stelmo on PR #667
Currently this requires a #dev version of Clarabel
…22-09-10-02-40-32-218-02454686738

CompatHelper: bump compat for SBML to 1, (keep existing compat)
- support CVTerms-based annotations in the usual way
  (thanks COBRApy for inspiration!)
- fix minor issues with notes and formula export
- prevent problems when exporting (some) non-SBMLizable metabolite names
(I need to depend on the fixes here)
Make the SBML annotations work just like with JSON models
docs: reflect the solver change in Project.toml
fix docbuild: JuMP `MIN_SENSE` and `MAX_SENSE` disappeared
triggered by @exaexa on PR #681
remove `polish` parameter specific to osqp
@exaexa exaexa added this to the v1.5 milestone Oct 14, 2022
@exaexa exaexa requested a review from stelmo October 14, 2022 09:38
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 90.43% // Head: 90.60% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (f66abed) compared to base (796ade3).
Patch coverage: 86.36% of modified lines in pull request are covered.

❗ Current head f66abed differs from pull request most recent head 677b099. Consider uploading reports for the commit 677b099 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   90.43%   90.60%   +0.16%     
==========================================
  Files          79       82       +3     
  Lines        1923     2149     +226     
==========================================
+ Hits         1739     1947     +208     
- Misses        184      202      +18     
Impacted Files Coverage Δ
src/COBREXA.jl 0.00% <ø> (ø)
src/analysis/flux_balance_analysis.jl 100.00% <ø> (ø)
src/analysis/flux_variability_analysis.jl 93.54% <ø> (ø)
src/analysis/gecko.jl 100.00% <ø> (ø)
src/analysis/max_min_driving_force.jl 93.84% <ø> (+0.51%) ⬆️
src/analysis/minimize_metabolic_adjustment.jl 66.66% <ø> (ø)
src/analysis/modifications/crowding.jl 100.00% <ø> (ø)
src/analysis/modifications/generic.jl 78.26% <ø> (+0.98%) ⬆️
src/analysis/modifications/knockout.jl 100.00% <ø> (ø)
src/analysis/modifications/loopless.jl 100.00% <ø> (ø)
... and 103 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

exaexa and others added 2 commits October 14, 2022 11:54
Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@exaexa exaexa merged commit c79ab7f into master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants