Make the SBML annotations work just like with JSON models #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support CVTerms-based annotations in the usual way (thanks COBRApy for inspiration!) - fix minor issues with notes and formula export - prevent problems when exporting (some) non-SBMLizable metabolite names
(I need to depend on the fixes here)
Codecov ReportBase: 91.00% // Head: 90.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #676 +/- ##
===========================================
- Coverage 91.00% 90.68% -0.33%
===========================================
Files 82 82
Lines 2012 2039 +27
===========================================
+ Hits 1831 1849 +18
- Misses 181 190 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports CV terms from SBML1.3 (and saves them back). Import and representation methodology is moreless the same as with cobra.:snake: . Because finally fixing this I bump 1.4.1.
There is a bunch of minor, partially surprising fixes that were packed along the way. Most notably there's no realistically good way to export notes to SBML
Cc @HettieC -- this should finally fix the whole annotation problem.