Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more efficient building of sparse stoichiometries #443

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Aug 18, 2021

Description

This is for JSON and Standard models. MATModel can't be optimized, CoreModel contains the stoichiometry as is, and SBMLModel builds the stoichiometry in SBML.jl (I will optimize it there).

Most notably, this vastly reduces load time of large StdModels, roughly to O(json_parsing_time).

Checklist

  • All code is formatted
  • Tests work
  • All new functions have proper docstrings (there are none)
  • Documentation builds correctly (no changes)

@exaexa exaexa requested a review from stelmo August 18, 2021 10:56
@cylon-x
Copy link
Collaborator

cylon-x commented Aug 18, 2021

🟢  Commit 73774a7 is formatted properly.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #443 (73774a7) into master (2df9398) will increase coverage by 0.28%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   89.47%   89.76%   +0.28%     
==========================================
  Files          59       59              
  Lines        1435     1465      +30     
==========================================
+ Hits         1284     1315      +31     
+ Misses        151      150       -1     
Impacted Files Coverage Δ
src/base/utils/Reaction.jl 97.36% <83.33%> (-2.64%) ⬇️
src/base/types/SBMLModel.jl 85.71% <85.71%> (-0.34%) ⬇️
src/base/types/JSONModel.jl 100.00% <100.00%> (+1.31%) ⬆️
src/base/types/StandardModel.jl 100.00% <100.00%> (+1.72%) ⬆️
src/reconstruction/community.jl 91.72% <100.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20e41f...73774a7. Read the comment docs.

Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants