Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted unnecessary dependency #291

Merged
merged 3 commits into from
Jun 1, 2021
Merged

Deleted unnecessary dependency #291

merged 3 commits into from
Jun 1, 2021

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Jun 1, 2021

replaced the mycoplasma model with iJR904.

@stelmo stelmo added the 🪓 code axing 🪓 Use this for PRs that remove code which might still be re-used later label Jun 1, 2021
@exaexa
Copy link
Collaborator

exaexa commented Jun 1, 2021

just a quick comment, you probably didn't want to commit the data files?

(not sure if I didn't mess up / forget the .gitignore tho.)

@stelmo
Copy link
Collaborator Author

stelmo commented Jun 1, 2021

just a quick comment, you probably didn't want to commit the data files?

(not sure if I didn't mess up / forget the .gitignore tho.)

Ah you are right! Strange, I think something is wrong with the gitignore. Will fix

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #291 (a5866cd) into master (07cfeaf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   89.80%   89.80%           
=======================================
  Files          49       49           
  Lines        1138     1138           
=======================================
  Hits         1022     1022           
  Misses        116      116           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 448741c...a5866cd. Read the comment docs.

@laurentheirendt laurentheirendt merged commit 8372bd2 into master Jun 1, 2021
@laurentheirendt laurentheirendt deleted the mo-no-mo-vmh branch June 1, 2021 08:50
laurentheirendt added a commit to laurentheirendt/COBREXA.jl that referenced this pull request Jun 8, 2021
Deleted unnecessary dependency

Former-commit-id: 8372bd2
exaexa pushed a commit that referenced this pull request Jul 8, 2021
Deleted unnecessary dependency

Former-commit-id: 8372bd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪓 code axing 🪓 Use this for PRs that remove code which might still be re-used later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants