Sorting Contribution Analysis tables better

[marc-vdm]

Currently, results tables in EF contributions and Process contributions sort the data (and also the graphs) based on the first data (numbers) column large >> small. While this is nice, it may be nicest to sort on the larges contributor in total. We could achieve this by temporarily creating a new column in the pandas df that takes the max() of the row, and sort the table on that. As these tables are generally not large, this extra step should not take any meaningful time.

Sorting the data like this would allow AB to show data based on the most relevant contributors in general, not just for the first process shown. e.g. the figure below, which is sorted on the lowest bar in the graph (and first column):

We could instead sort on the largest contributors in total, like the excel example below:

This should be done here:

activity-browser/activity_browser/bwutils/multilca.py

Line 393 in 1715a17

top_contribution = ca.sort_array(C[col, :], limit=limit, limit_type=limit_type)

ca.sort_array() both sorts and filters the data. We can re-sort afterwards with the improved sorting.

we can sort like this (source):

maxCol = lambda x: max(x.min(), x.max(), key=abs)

For the second sorting on this col, we can assume almost sorted arrangement, and thus we should use Timsort, as explained here

[github-actions]

Note

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.11.0), you can get the new version by updating Activity Browser.

Do you want to be notified of new releases of Activity Browser? Subscribe to our updates mailing list ✉.

🤖 beep boop! I'm a bot and this message was an automated action.
If updating does not make sense for this issue, just ignore this.