Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution analysis rest row sometimes doesn't show in table + index missing #1044

Closed
1 task done
marc-vdm opened this issue Sep 22, 2023 · 1 comment · Fixed by #1046
Closed
1 task done

Contribution analysis rest row sometimes doesn't show in table + index missing #1044

marc-vdm opened this issue Sep 22, 2023 · 1 comment · Fixed by #1046
Labels
bug Issues/PRs related to bugs
Milestone

Comments

@marc-vdm
Copy link
Member

marc-vdm commented Sep 22, 2023

Updating AB

  • Yes, I have updated AB and still experience this issue

What happened?

The rest row doesn't always show in table while present in the figure, so far, I've only seen it in ProcessContributions, but not sure if that's a pattern or coincidence.

The missing index was a mistake and not actually a problem

Relevant errors

No response

Operating system

Windows 10

Conda environment

No response

@marc-vdm marc-vdm added the bug Issues/PRs related to bugs label Sep 22, 2023
@marc-vdm marc-vdm changed the title Contribution analysis rest row sometimes doesn't show in table Contribution analysis rest row sometimes doesn't show in table + index missing Sep 22, 2023
@marc-vdm marc-vdm added this to the 2.9.2 milestone Oct 11, 2023
@marc-vdm marc-vdm modified the milestones: 2.9.2, 2.9.3 Oct 21, 2023
@marc-vdm marc-vdm modified the milestones: 2.9.3, 2.9.4 Nov 22, 2023
@mrvisscher mrvisscher removed this from the 2.9.4 milestone Jan 9, 2024
marc-vdm added a commit to marc-vdm/activity-browser that referenced this issue Sep 29, 2024
Add:
- CA data: use actual total instead of sum(abs)
- CA data: make distinction between positive and negative rest values (LCA-ActivityBrowser#886)
- CA data: sort based on average of row instead of first column (LCA-ActivityBrowser#887)
- CA table: consistent dropping of empty (rest) rows (LCA-ActivityBrowser#1044)
- CA figure: add marker to show total score when both positive and negative results present (LCA-ActivityBrowser#647)
@marc-vdm marc-vdm mentioned this issue Sep 29, 2024
7 tasks
@marc-vdm marc-vdm added this to the 2.11.0 milestone Sep 30, 2024
Copy link

github-actions bot commented Jan 2, 2025

Note

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.11.0), you can get the new version by updating Activity Browser.

Do you want to be notified of new releases of Activity Browser? Subscribe to our updates mailing list ✉.

🤖 beep boop! I'm a bot and this message was an automated action.
If updating does not make sense for this issue, just ignore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
2 participants