Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/larpandoracontent v04 07 00 #61

Merged
merged 10 commits into from
Feb 8, 2024

Conversation

knoepfel
Copy link
Member

@knoepfel knoepfel commented Feb 5, 2024

Includes changes from #60, plus application of format-code.

@FNALbuild
Copy link

A new Pull Request was created by @knoepfel (Kyle Knoepfel) for develop.

It involves the following packages:

larpandoracontent

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link

+code-checks

@knoepfel
Copy link
Member Author

knoepfel commented Feb 5, 2024

trigger build

@FNALbuild
Copy link

The tests are being triggered in jenkins.

@FNALbuild
Copy link

-LArSoft tests failed on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21717&builds=
-build

@FNALbuild
Copy link

-LArSoft tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21718&builds=
-build

@AndyChappell
Copy link

Includes changes from #60, plus application of format-code.

Thanks Kyle.

@knoepfel
Copy link
Member Author

knoepfel commented Feb 5, 2024

trigger build

@FNALbuild
Copy link

The tests are being triggered in jenkins.

@FNALbuild
Copy link

Pull request #61 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

@FNALbuild
Copy link

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link

+code-checks

@FNALbuild
Copy link

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21721&builds=
+build

@FNALbuild
Copy link

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21720&builds=
+build

@FNALbuild
Copy link

@FNALbuild
Copy link

@FNALbuild
Copy link

@lgarren
Copy link
Member

lgarren commented Feb 6, 2024

@AndyChappell Would you take a look at the uboone CI failure? It's not clear if the problem is related to this PR.

@lgarren
Copy link
Member

lgarren commented Feb 6, 2024

@AndyChappell
Copy link

@lgarren This appears to be a problem at the generator stage with a missing registry key NGenerators, so this is unrelated to this PR.

@lgarren
Copy link
Member

lgarren commented Feb 7, 2024

Thanks @AndyChappell

@lgarren
Copy link
Member

lgarren commented Feb 7, 2024

approve

@FNALbuild
Copy link

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

@lgarren lgarren merged commit 51f83a9 into develop Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Included in release
Development

Successfully merging this pull request may close these issues.

6 participants