-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/larpandoracontent_v04_07_00 #60
feature/larpandoracontent_v04_07_00 #60
Conversation
SlicingAlgorithm.h
…sses Feature/lhw extract base classes: extract various classes and base classes from other header files
…_05_02 feature/lhw_extract_base_classes
…_alg Vertex Refinement Bug
A new Pull Request was created by @AndyChappell for develop. It involves the following packages: larpandoracontent @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
-code-checks
Then commit the changes and push them to your PR branch. |
Not sure what's going on with the code checks. Running format-code across all of these files indicates no changes are being made. |
trigger build |
The tests are being triggered in jenkins. |
@AndyChappell , we have an idea of what may be happening with the code checks. Working to sort that out, but proceeding with the CI tests for this PR. |
+LArSoft tests OK on slf7 for c14:prof |
+LArSoft tests OK on slf7 for e26:prof |
-icarus tests warning on slf7 for e26:prof |
-sbnd tests warning on slf7 for e26:prof |
-dune tests tests failed on slf7 for e26:prof |
-uboone tests failed on slf7 for e26:prof |
Some formatting changes were actually required based on https://github.com/LArSoft/larpandoracontent/blob/develop/.clang-format. I've opened a new PR (#61) with those changes applied. |
This PR for larpandoracontent v04_07_00 includes refactoring of a number of classes to support ongoing DUNE ND development efforts (no functionality is changed). There is also a fix for a bug in the way cluster contribution weights are calculated in the vertex refinement algorithm. This latter change is only relevant to SBND, where product changes are anticipated.