feature/larpandoracontent_v04_07_00

[AndyChappell]

This PR for larpandoracontent v04_07_00 includes refactoring of a number of classes to support ongoing DUNE ND development efforts (no functionality is changed). There is also a fix for a bug in the way cluster contribution weights are calculated in the vertex refinement algorithm. This latter change is only relevant to SBND, where product changes are anticipated.

[FNALbuild]

A new Pull Request was created by @AndyChappell for develop.

It involves the following packages:

larpandoracontent

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larpandoracontent/LArCheating/CheatingCosmicRayTaggingTool.h \ 
  larpandoracontent/LArCheating/CheatingEventSlicingTool.h \ 
  larpandoracontent/LArControlFlow/CosmicRayTaggingBaseTool.h \ 
  larpandoracontent/LArControlFlow/CosmicRayTaggingTool.h \ 
  larpandoracontent/LArControlFlow/EventSlicingBaseTool.h \ 
  larpandoracontent/LArControlFlow/MasterAlgorithm.h \ 
  larpandoracontent/LArControlFlow/SliceIdBaseTool.h \ 
  larpandoracontent/LArControlFlow/SliceSelectionBaseTool.h \ 
  larpandoracontent/LArControlFlow/SlicingAlgorithm.h \ 
  larpandoracontent/LArControlFlow/StitchingBaseTool.h \ 
  larpandoracontent/LArObjects/LArSlice.h \ 
  larpandoracontent/LArThreeDReco/LArEventBuilding/EventSlicingTool.h \ 
  larpandoracontent/LArVertex/VertexRefinementAlgorithm.cc

Then commit the changes and push them to your PR branch.

[AndyChappell]

-code-checks Pull request failed...

Not sure what's going on with the code checks. Running format-code across all of these files indicates no changes are being made.

[knoepfel]

trigger build

[FNALbuild]

The tests are being triggered in jenkins.

[lgarren]

@AndyChappell , we have an idea of what may be happening with the code checks. Working to sort that out, but proceeding with the CI tests for this PR.

[FNALbuild]

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21715&builds=
+build

[FNALbuild]

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21716&builds=
+build

[FNALbuild]

-icarus tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/9124&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21716&builds=

[FNALbuild]

-sbnd tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/13504&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21716&builds=

[FNALbuild]

-dune tests tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/16744&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21716&builds=

[FNALbuild]

-uboone tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uboone/view_builds/index?offset=0&builds=uboone_ci/10184&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/21716&builds=

[knoepfel]

Some formatting changes were actually required based on https://github.com/LArSoft/larpandoracontent/blob/develop/.clang-format. I've opened a new PR (#61) with those changes applied.