Feature/standalone config generation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i guess coveralls is asking me to write a test for the new |
lrascao
force-pushed
the
feature/standalone_config_generation
branch
2 times, most recently
from
2a09605 to
d4df9d2
Compare
|
@lrascao @lukebakken I like this idea |
|
ping, is this missing something or just not enough bandwidth atm? |
|
@lrascao please remember that this free, open source software is maintained by volunteers. |
|
i understand that completely as i maintain a few of my own, wasn't my intention to put anyone under pressure, just wondering if this had slipped under the radar, now i know it's not |
We're not interested in generating `erlexec` cli args, the job was already done which is generating the config file.
Depending on wether the dest_file parameter is a complete filename with extension, skip or append the datetime suffix at the end of it.
lrascao
force-pushed
the
feature/standalone_config_generation
branch
from
99be8b8 to
d348ee4
Compare
|
i've rebased onto master for a cleaner history |
lukebakken
approved these changes
Oct 22, 2020
|
Thank you! |
|
thanks! i've got another one in the pipe that is in the same vein, but for vm.args, maybe hold off a bit on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits will bring
cuttlefishto a point where i'm able to invoke:cuttlefish --etc_dir etc --dest_dir output_dir --dest_file generated.config --schema_dir path_to/schemas --conf_file etc/a_conf_file.conf --allow_extra --silentThis invocation will look in
path_to/schemas, find all.schemafiles and generate a single .config file tooutput_dir/generate.configbased on values expressed inetc/a_conf_file.conf.In my particular use case i'm not interested in generating
vm.argsor a full fledgedsys.configfile. I only want to take advantage of cuttlefish's schema/conf functionality to generate a single tuple-based .config file.