Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/standalone vm args generation #12

Merged

Conversation

lrascao
Copy link
Contributor

@lrascao lrascao commented Nov 3, 2020

This picks up the intent from the previous PR and expands it to also apply to generated vm.args file that apt to be included by way of the -args_file VM option.

@lrascao
Copy link
Contributor Author

lrascao commented Nov 4, 2020

Will add some tests to improve coverage

The `dest_file` parameter can now be supplied as well for standalone generation of `vm.args` files,
this allows generation of multiple `vm.args` type files that can be include from one another through
the `-args_file` parameter.
@lrascao lrascao force-pushed the feature/standalone_vm_args_generation branch from 7b42d01 to 13ebade Compare November 4, 2020 11:39
@lrascao
Copy link
Contributor Author

lrascao commented Nov 5, 2020

Will add some tests to improve coverage

done, ready for review

@lukebakken lukebakken added this to the 2.5.0 milestone Nov 9, 2020
@lukebakken lukebakken self-assigned this Nov 9, 2020
@lukebakken lukebakken self-requested a review November 9, 2020 16:20
@lukebakken lukebakken merged commit 860aa1e into Kyorai:master Nov 30, 2020
@lukebakken
Copy link
Collaborator

Thank you!

@lrascao lrascao deleted the feature/standalone_vm_args_generation branch December 2, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants