-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new domain_socket data type #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll use this in VerneMQ and think it's a useful datatype to add to Cuttlefish.
Thanks @ioolkos, pinging @michaelklishin @lukebakken for visibility. |
Something is off with Erlang provisioning on Actions. I don't have any objections to adding this new data type. |
Thanks, i know wbat the GHA problem is, going to fix it here |
@codeadict thanks for pinging me. I didn't get or didn't notice an email about this PR. Thanks for taking a look at GHA! |
Awesome @lukebakken , you can give a shot now to running the Github actions 🤞🏽 |
author Dairon Medina Caro <dmedinacaro@cars.com> 1674855971 -0500 committer Luke Bakken <luke@bakken.io> 1676314181 -0800 gpgsig -----BEGIN PGP SIGNATURE----- iQJDBAABCAAtFiEEsbgswM+EunAUfr0F2Z3jDkPq5EAFAmPqhkUPHGx1a2VAYmFr a2VuLmlvAAoJENmd4w5D6uRAdOIP/1f/JeDldc5ygq164ERRa6VbUGSQTluHEY/o 0pXfs5nelmfws2e12MFyvxK8ar+qLg/XyN6Y/HUZBFLgwX/qwsgwDtZv8uT0X4bW 1yb26UsG22Q/oIv3aBYOGl/Nrkqch+Pw2TGJBynSIznYVXqDOd+LbQG5aXrZbfCd 2xMpESnGeCFTsEpjgsNZu7vPKeDjBHeCN24EMi2DtPaC9xzb4PHhriDvCgS2YdpX bhjmFfAUv0v27PS+6GN7SqygRkRgiplpvEM3ToNVePS6lPdMpz6dsOO1NFcnzmY/ +AT+okaILgIGwof/nF2QFtbEMkzTSnml9P7FtsaDjlrTmn9yVEN5q5hoHSVBaTMS ISmOFGKsx3W5YJtgb4gp0UzSAktK9e1jjhcd7160hO/DCv7LvzC33lJVHlXK0Ep6 vvRuOfbdhFOIFsTUBqz7cHoCIckz7smlohFi57znKop3DINEsq9cnbFBaqSKTAzE r+KRZOxQpc9Fv1j69DS6ASfM4gv9vPjgCJaTDRI4XZKUY6WWJCfxkY8pN4h6RLMz AhyDp/4IpDr8wafCg8dZcIgrDSnY+sWd3RkSaiWp4TfOjtFWb+D1gpyuBfgaZWHV 1clNDvI2A7TJpJVOArhZpBfqFHijJwCuVzuGYkBTAOaowiJGNkk9kVOtdgq4b32R m7kRBCZ2 =k54M -----END PGP SIGNATURE----- Add support for Unix Domain Sockets type Simplify domain sockets Validate only 0 port can be provided Use same format expected by inets ci: Normalize GHA string quotes
caf373e
to
1972c39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codeadict some of the quoting changes in the GHA workflow file were invalid. I like single quotes anyway 😉 Waiting for GHA to finish then I'll merge.
PS I cherry-picked your changes into #34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like dialyzer failed:
src/cuttlefish_datatypes.erl
Line 332 Column 1: The pattern <String, _UDSStr, _, 'undefined'> can never match the type <string(),string(),{'match',nonempty_string()},0>
===> Warnings written to _build/default/25.2.2.dialyzer_warnings
===> Warnings occurred running dialyzer: 1
Thanks @lukebakken . Yeah no hard opinion on the quotes, my editor as changing them all the time on save to double quotes but i just figured it was the prettier extension I had enabled. |
🎉 |
@ioolkos @codeadict here you go! https://github.com/Kyorai/cuttlefish/releases/tag/v3.2.0 THANKS! PS I'm getting hex.pm right now... |
Yay, thanks @lukebakken! :) |
Thanks a lot. cheers! |
Adds
domain_socket
as a new datatype, separate from the existingip
but with the convenience of parsing "local:/path/to/your.sock:0" or "unix:/path/to/your.sock:0" into {local, "/path/to/your.sock", 0} , following the type at https://www.erlang.org/doc/man/inet.html#type-local_address.