Config for unix socket listeners

[ioolkos]

I'd like to use Cuttlefish configuration for unix domain sockets similar to the following config snippet:

listener.tcp.default = 127.0.0.1:1883  ##normal listener
listener.tcp.unix_socket = local:/tmp/my.sock:0  ## uds listener

This will currently be captured and disallowed by the ip datatype validation here:

cuttlefish/src/cuttlefish_datatypes.erl

Line 302 in a0a3ed5

from_string_to_ip(String, {IpPlusColon, PortString}) ->

Would an extension to that ip validation be the right approach? better ideas?

[michaelklishin]

Let's not extend the ip type and introduce a new one instead. domain_socket is what I'd use.

[ioolkos]

I understand. The thing is that this will lead to tons of duplicate boilerplate in your schema files (the domain socket will use TCP transport, can theoretically even use SSL).

I think the best approach is to go just one step further and introduce a new datatype that corresponds to the Erlang socket_address so that it can match an IP address and a local address: http://erlang.org/doc/man/inet.html#type-socket_address
This will leave the existing ip type untouched.

[michaelklishin]

Sounds good.

[ioolkos]

I'll provide a PR. Will take a while as I need it to be part of a working end-to-end implementation.
Thanks!

[codeadict]

@ioolkos - Should we open a PR with your implementation on https://github.com/ioolkos/cuttlefish/tree/feature_domain_socket?

[ioolkos]

@codeadict Thanks, I forgot about this. It was just a quick hack but we can open a PR. In relation to Verne itself, there's still a minor issue: vernemq/vernemq#2008
I think the ip_or_domain data type messes up the initial default listener creation... maybe I haven't added a translation or sth similar.

[codeadict]

@ioolkos I think you can alsp have a single type, like domain_socket and specify 2 types in the schema like [ip, domain_socket] instead of having a composed type

[codeadict]

@ioolkos Added PR #33 that fixes the VerneMQ issues we are facing with releases now