Highlight buttons when redirecting from About page #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhoaidanh
approved these changes
Jul 19, 2022
Auto Deploy Pull RequestYour domain dmm-interface-1142.pr.kyberengineering.io has been created. Notes
|
shorten them as |
viet-nv
deleted the
feature/highlight-buttons-when-redirecting-from-about
branch
Auto Deploy Pull RequestYour domain dmm-interface-1142.pr.kyberengineering.io has been revoked because: PR closed. Notes
|
@nguyenhoaidanh @namgold We may not need to care for the length because users won't type it. If we shorten to |
|
Actually we can infer it by assign a const. This help link shorter, imo this is better |
|
User dont type it but they share it @hungdoansy |
viet-nv
added a commit
that referenced
this pull request
Jul 25, 2022
* init * style: change background color * style: swwap page * style: swap form * move recipient to address input * finish swap page * fix: detail box animation * style: pools page * style: redesign pools page * update action button icon * pools page * mypools page * mypools page * classic pools page * style: about page * style: trending soon * style: truesight * add/remove liquidity elastic * addliquidity classic * add/remove liquidity * leader board * fiX: increase liquidity rinkeby * feat(add liquidity elastic): change select fee style * style: update max/half btn * feat: fee tier distribution * feat: add instruction text for pools * farm guide * Swap Transaction settings (#1123) * wip * wip: rename legacy toggle and the new toggle * wip: transaction time limit setting * wip: refactor toggle to use in darker background * wip: slippage setting * wip: transaction time limit setting * wip: swap settings panel * wip: advanced mode setting * wip: swap settings panel * wip: swap settings panel * wip: advanced mode setting and modal * wip(toggle): move Dot out of Toggle * style: elastic farm * style: classic farm * fix: mix panel crash * style: fix farm page css * fix: switch token on swap page * feat(swap-settings): add liquidity sources setting/panel (#1130) * feat(swap-settings): implement GasPriceTracker panel (#1129) Co-authored-by: viet-nv <vietnv1304@gmail.com> * style: fix select a token text on add liquidity when screen is too small * fix: receipient issue when turn off expert mode * style: my pool layout * fix: liquidity source * popups * fix(gas-price-tracker): correct DeBank slug for optimism * fix: cant switch/select token when we have in/output currency on url * style(token-modal): update ui * show common bases on pools select token * refactor(network-modal): duplicate component on wrong network modal * Highlight buttons when redirecting from About page (#1142) * feat(pool): highlight Add Liquidity button when redirecting from About * chore(about): update text color of View Farms button * fix: recipient still there when turn off advance mode * style(pro-chart): update background color * feat(pools): add stable pools filter * style(farm) * fix: reset page to 1 when select stable pools * style(classic-vesting): vesting summary * style: classic vesting * refactor(slippage-setting): split components * fix: layout issue * feat(liquidity-sources-panel): show scroll bar * feat(swap): highlight Swap box when redirecting from About page * add claim popup * change bnb elastic subgraph to prod account * update live chart mobile * update knc about text * update tutorial linkl * style: farm page * syle: tweak some ui * fix: kami comment * fix: prakhar comment * style(about): use ButtonLight for View Farms * fix: balace * update tutorial popup * fixed comment * chore: highlight buttons when URL params match the condition * chore(aggregator-stats): add header to get the latest version of API * style(advance-mode-popup): refactor to reuse advance mode popup * change container size of campaign and truesight * add tooltip on swap setting * fix: swap form is not central * only show 5 tx in account detail popup * fix: header dropdown Co-authored-by: Hung Doan <19758667+hungdoansy@users.noreply.github.com> Co-authored-by: Doan Sy Hung <hungdoansy@gmail.com>
nguyenhoaidanh
added a commit
that referenced
this pull request
Aug 5, 2022
* init * style: change background color * style: swwap page * style: swap form * move recipient to address input * finish swap page * fix: detail box animation * style: pools page * style: redesign pools page * update action button icon * pools page * mypools page * mypools page * classic pools page * style: about page * style: trending soon * style: truesight * add/remove liquidity elastic * addliquidity classic * add/remove liquidity * leader board * fiX: increase liquidity rinkeby * feat(add liquidity elastic): change select fee style * style: update max/half btn * feat: fee tier distribution * feat: add instruction text for pools * farm guide * Swap Transaction settings (#1123) * wip * wip: rename legacy toggle and the new toggle * wip: transaction time limit setting * wip: refactor toggle to use in darker background * wip: slippage setting * wip: transaction time limit setting * wip: swap settings panel * wip: advanced mode setting * wip: swap settings panel * wip: swap settings panel * wip: advanced mode setting and modal * wip(toggle): move Dot out of Toggle * style: elastic farm * style: classic farm * fix: mix panel crash * style: fix farm page css * fix: switch token on swap page * feat(swap-settings): add liquidity sources setting/panel (#1130) * feat(swap-settings): implement GasPriceTracker panel (#1129) Co-authored-by: viet-nv <vietnv1304@gmail.com> * style: fix select a token text on add liquidity when screen is too small * fix: receipient issue when turn off expert mode * style: my pool layout * fix: liquidity source * popups * fix(gas-price-tracker): correct DeBank slug for optimism * fix: cant switch/select token when we have in/output currency on url * style(token-modal): update ui * show common bases on pools select token * refactor(network-modal): duplicate component on wrong network modal * Highlight buttons when redirecting from About page (#1142) * feat(pool): highlight Add Liquidity button when redirecting from About * chore(about): update text color of View Farms button * fix: recipient still there when turn off advance mode * style(pro-chart): update background color * feat(pools): add stable pools filter * style(farm) * fix: reset page to 1 when select stable pools * style(classic-vesting): vesting summary * type && swap tobe continue * chore * style: classic vesting * split component * refactor(slippage-setting): split components * fix: layout issue * feat(liquidity-sources-panel): show scroll bar * feat(swap): highlight Swap box when redirecting from About page * add claim popup * token info Accordion . * change bnb elastic subgraph to prod account * update live chart mobile * update knc about text * update tutorial linkl * rm unuse package * update tutorial linkl * style: farm page * syle: tweak some ui * update ux * fix some eslint * fix: kami comment * fix: prakhar comment * style(about): use ButtonLight for View Farms * fix: balace * update tutorial popup * update tutorial popup * fixed comment * chore: highlight buttons when URL params match the condition * chore(aggregator-stats): add header to get the latest version of API * style(advance-mode-popup): refactor to reuse advance mode popup * change container size of campaign and truesight * add tooltip on swap setting * fix: swap form is not central * only show 5 tx in account detail popup * fix: header dropdown * fix conflict * connect api get * build add/remove pairt fix find token intergrade api * use logo * build update ux * update ux update feedback prakhar update uxx fix: can not import . update ux update ux * fix conflict * update ux * sort pair * fix: chain network not refetch * fix ctrl+k window * fix amount wrong show favorite only login refresh after add/remove pairs search favorite pair update ux update color design enter feature update color mobile . fix: text overflow split component . . * remove conflict qs * enter to import token modal * icon enter button icon enter button fix wrong order rm unuse * update api * update feedback * fix feedback * update feedback * add comment * update feedback * update feedback * update text token info * update feedback * update feedback * update feedback * update feedback * fix issues: chớp token warning * fix css * fix ios outline * tracking, toast. . alert warning * fix conflict * add tracking * update tooltip * update font * fix bug: not show toast after typing * fix: popup close nearest * fix notipopup * fix bug change change * fix blur * refactor popup * fix bug can not like pair * update api Co-authored-by: Nguyen Van Viet <vietnv1304@gmail.com> Co-authored-by: Hung Doan <19758667+hungdoansy@users.noreply.github.com> Co-authored-by: Doan Sy Hung <hungdoansy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to highlight the Add Liquidity button when users click Start Eearning buttons in About page. Also, Kami requested to update the text color of the View Farms button so that the icon and the text share the same color