Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display gas prices for each chain (in Settings) #1129

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Display gas prices for each chain (in Settings) #1129

merged 2 commits into from
Jul 18, 2022

Conversation

hungdoansy
Copy link
Contributor

@hungdoansy hungdoansy commented Jul 14, 2022 •
edited
Loading

Requirement

  • Display Low, Average and High gas prices for Swap transactions.

Implementation

  • Use DeBank API to fetch gas prices, it's easy, but for example, its data is not the same as in https://etherscan.io/gastracker
  • Use fixed 190_000 gas units when calculating the minimum tx fee of a swap

@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain dmm-interface-1129.pr.kyberengineering.io has been created.

Notes

  • Please wait up to 60s, we need to pull your image.
  • This domain only validity until this PR is closed

@hungdoansy hungdoansy force-pushed the feature/display-gas-price branch 2 times, most recently from 18fd232 to a8f1ae6 Compare July 15, 2022 12:38
@hungdoansy hungdoansy marked this pull request as ready for review July 15, 2022 12:40
@hungdoansy hungdoansy force-pushed the feature/display-gas-price branch 2 times, most recently from 94b0bec to f0bb9d0 Compare July 15, 2022 12:56
namgold
namgold reviewed Jul 15, 2022
View reviewed changes
src/constants/networks/oasis.ts Outdated
@@ -62,6 +62,7 @@ const oasisInfo: NetworkInfo = {
avgrageBlockTimeInSeconds: 10,
coingeckoNetworkId: 'oasis',
coingeckoNativeTokenId: 'oasis-network',
deBankSlug: '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use EMPTY instead of ''

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, updated

@hungdoansy hungdoansy force-pushed the feature/display-gas-price branch from f0bb9d0 to 6e1d1b2 Compare July 17, 2022 01:59
@viet-nv viet-nv merged commit 35a4337 into feature/modern-theme Jul 18, 2022
@viet-nv viet-nv deleted the feature/display-gas-price branch July 18, 2022 03:42
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain dmm-interface-1129.pr.kyberengineering.io has been revoked because: PR closed.

Notes

  • Please re-open the PR to re-create this domain!

viet-nv added a commit that referenced this pull request Jul 25, 2022
@viet-nv @hungdoansy
Feature/modern theme (#1065)
8ab78cd 
* init

* style: change background color

* style: swwap page

* style: swap form

* move recipient to address input

* finish swap page

* fix: detail box animation

* style: pools page

* style: redesign pools page

* update action button icon

* pools page

* mypools page

* mypools page

* classic pools page

* style: about page

* style: trending soon

* style: truesight

* add/remove liquidity elastic

* addliquidity classic

* add/remove liquidity

* leader board

* fiX: increase liquidity rinkeby

* feat(add liquidity elastic): change select fee style

* style: update max/half btn

* feat: fee tier distribution

* feat:  add instruction text for pools

* farm guide

* Swap Transaction settings (#1123)

* wip

* wip: rename legacy toggle and the new toggle

* wip: transaction time limit setting

* wip: refactor toggle to use in darker background

* wip: slippage setting

* wip: transaction time limit setting

* wip: swap settings panel

* wip: advanced mode setting

* wip: swap settings panel

* wip: swap settings panel

* wip: advanced mode setting and modal

* wip(toggle): move Dot out of Toggle

* style: elastic farm

* style: classic farm

* fix: mix panel crash

* style: fix farm page css

* fix: switch token on swap page

* feat(swap-settings): add liquidity sources setting/panel (#1130)

* feat(swap-settings): implement GasPriceTracker panel (#1129)

Co-authored-by: viet-nv <vietnv1304@gmail.com>

* style: fix select a token text on add liquidity when screen is too small

* fix: receipient issue when turn off expert mode

* style: my pool layout

* fix: liquidity source

* popups

* fix(gas-price-tracker): correct DeBank slug for optimism

* fix: cant switch/select token when we have in/output currency on url

* style(token-modal): update ui

* show common bases on pools select token

* refactor(network-modal): duplicate component on wrong network modal

* Highlight buttons when redirecting from About page (#1142)

* feat(pool): highlight Add Liquidity button when redirecting from About

* chore(about): update text color of View Farms button

* fix: recipient still there when turn off advance mode

* style(pro-chart): update background color

* feat(pools): add stable pools filter

* style(farm)

* fix: reset page to 1 when select stable pools

* style(classic-vesting): vesting summary

* style: classic vesting

* refactor(slippage-setting): split components

* fix: layout issue

* feat(liquidity-sources-panel): show scroll bar

* feat(swap): highlight Swap box when redirecting from About page

* add claim popup

* change bnb elastic subgraph to prod account

* update live chart mobile

* update knc about text

* update tutorial linkl

* style: farm page

* syle: tweak some ui

* fix: kami comment

* fix: prakhar comment

* style(about): use ButtonLight for View Farms

* fix: balace

* update tutorial popup

* fixed comment

* chore: highlight buttons when URL params match the condition

* chore(aggregator-stats): add header to get the latest version of API

* style(advance-mode-popup): refactor to reuse advance mode popup

* change container size of campaign and truesight

* add tooltip on swap setting

* fix: swap form is not central

* only show 5 tx in account detail popup

* fix: header dropdown

Co-authored-by: Hung Doan <19758667+hungdoansy@users.noreply.github.com>
Co-authored-by: Doan Sy Hung <hungdoansy@gmail.com>
nguyenhoaidanh added a commit that referenced this pull request Aug 5, 2022
@nguyenhoaidanh @viet-nv @hungdoansy
Danh/type and swap (#1148)
0075dcf 
* init

* style: change background color

* style: swwap page

* style: swap form

* move recipient to address input

* finish swap page

* fix: detail box animation

* style: pools page

* style: redesign pools page

* update action button icon

* pools page

* mypools page

* mypools page

* classic pools page

* style: about page

* style: trending soon

* style: truesight

* add/remove liquidity elastic

* addliquidity classic

* add/remove liquidity

* leader board

* fiX: increase liquidity rinkeby

* feat(add liquidity elastic): change select fee style

* style: update max/half btn

* feat: fee tier distribution

* feat:  add instruction text for pools

* farm guide

* Swap Transaction settings (#1123)

* wip

* wip: rename legacy toggle and the new toggle

* wip: transaction time limit setting

* wip: refactor toggle to use in darker background

* wip: slippage setting

* wip: transaction time limit setting

* wip: swap settings panel

* wip: advanced mode setting

* wip: swap settings panel

* wip: swap settings panel

* wip: advanced mode setting and modal

* wip(toggle): move Dot out of Toggle

* style: elastic farm

* style: classic farm

* fix: mix panel crash

* style: fix farm page css

* fix: switch token on swap page

* feat(swap-settings): add liquidity sources setting/panel (#1130)

* feat(swap-settings): implement GasPriceTracker panel (#1129)

Co-authored-by: viet-nv <vietnv1304@gmail.com>

* style: fix select a token text on add liquidity when screen is too small

* fix: receipient issue when turn off expert mode

* style: my pool layout

* fix: liquidity source

* popups

* fix(gas-price-tracker): correct DeBank slug for optimism

* fix: cant switch/select token when we have in/output currency on url

* style(token-modal): update ui

* show common bases on pools select token

* refactor(network-modal): duplicate component on wrong network modal

* Highlight buttons when redirecting from About page (#1142)

* feat(pool): highlight Add Liquidity button when redirecting from About

* chore(about): update text color of View Farms button

* fix: recipient still there when turn off advance mode

* style(pro-chart): update background color

* feat(pools): add stable pools filter

* style(farm)

* fix: reset page to 1 when select stable pools

* style(classic-vesting): vesting summary

* type && swap 

tobe continue

* chore

* style: classic vesting

* split component

* refactor(slippage-setting): split components

* fix: layout issue

* feat(liquidity-sources-panel): show scroll bar

* feat(swap): highlight Swap box when redirecting from About page

* add claim popup

* token info Accordion


.

* change bnb elastic subgraph to prod account

* update live chart mobile

* update knc about text

* update tutorial linkl

* rm unuse package

* update tutorial linkl

* style: farm page

* syle: tweak some ui

* update ux

* fix some eslint

* fix: kami comment

* fix: prakhar comment

* style(about): use ButtonLight for View Farms

* fix: balace

* update tutorial popup

* update tutorial popup

* fixed comment

* chore: highlight buttons when URL params match the condition

* chore(aggregator-stats): add header to get the latest version of API

* style(advance-mode-popup): refactor to reuse advance mode popup

* change container size of campaign and truesight

* add tooltip on swap setting

* fix: swap form is not central

* only show 5 tx in account detail popup

* fix: header dropdown

* fix conflict

* connect api get

* build


add/remove pairt


fix find token


intergrade api

* use logo

* build


update ux

* update ux


update feedback prakhar


update uxx


fix: can not import


.


update ux


update ux

* fix conflict

* update ux

* sort pair

* fix: chain network not refetch

* fix ctrl+k window

* fix amount wrong


show favorite only login


refresh after add/remove pairs


search favorite pair


update ux


update color design


enter feature


update color mobile


.


fix: text overflow


split component


.


.

* remove conflict qs

* enter to import token modal

* icon enter button


icon enter button


fix wrong order 


rm unuse

* update api

* update feedback

* fix feedback

* update feedback

* add comment

* update feedback

* update feedback

* update text token info

* update feedback

* update feedback

* update feedback

* update feedback

* fix issues: chớp token warning

* fix css

* fix ios outline

* tracking, toast.


.


alert warning

* fix conflict

* add tracking

* update tooltip

* update font

* fix bug: not show toast after typing

* fix: popup close nearest

* fix notipopup

* fix bug change change

* fix blur

* refactor popup

* fix bug can not like pair

* update api

Co-authored-by: Nguyen Van Viet <vietnv1304@gmail.com>
Co-authored-by: Hung Doan <19758667+hungdoansy@users.noreply.github.com>
Co-authored-by: Doan Sy Hung <hungdoansy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namgold namgold namgold left review comments

@viet-nv viet-nv viet-nv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hungdoansy @kyber-ci-bot @viet-nv @namgold