-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ModelPart #84
Adding ModelPart #84
Conversation
more discussion points:
// reference_wrapper<Node>
for (auto node_it=element.NodesBegin(); node_it!=element.NodesEnd(); ++node_it) {
node_it->get().Id();
}
// Node*
for (auto node_it=element.NodesBegin(); node_it!=element.NodesEnd(); ++node_it) {
(*node_it)->Id();
} => maybe we can have our own iterator that dereferences things right away?
|
@pooyan-dadvand I think this is ready. I would merge as is such that I can make the C and the Python interface. Once those are done then we are sure the basic capabilities work across languages and we can refine it / start using it for future PRs:
|
@philbucher I think you are missing the element type in the element and also in the CreateNewElement interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philbucher I think you are missing the element type in the element and also in the CreateNewElement interface
no it is there
|
||
Element( | ||
const IdType I_Id, | ||
const ElementType I_Type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is here
|
||
Element& CreateNewElement( | ||
const IdType I_Id, | ||
const Element::ElementType I_Type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
Let me go and prepare myself another coffee! Seems that I need it! |
I just got confused between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving after a coffee! 👍
This adds the
ModelPart
for the CoSimIO, which will serve as data-container esp for exchanging Mesh and (Geometry in the future)I decided to follow the interface we have in Kratos to not overcomplicate / reinvent the wheel
To be discussed:
private
/public
? => publicstd::size_t
ok? => thinking of MPI => typedef tostd::ptrdiff_t
(for reference: long index discussion in Kratos)CoSimIO
namespace is missing :)IndexType
andCoordinatesType
to define.h