You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
split connection_name to make usage easier (probably into name and connection_partner => consider that this has to be given to all the functions. Or maybe return a connection_name that should be used in further calls?) => Improve connect interface #65
Implement Import/Export with objects (e.g. Mesh for enhanced functionalities)
Implement File-Communication in folder (better prevention of deadlocks with leftover files)
add some data container such that data doesn't have to be copied all the time for Python (probably some thin wrapper around std::vector) => [Python] adding Vector #118
since it is very unlikely that we move to C++17 I would seriously consider including the C++11 version of std::filesystem. I think it will be worth it and reduce many problematic cases
Otherwise many things become much more difficult (e.g. deadlocks bcs of leftover files from previous runs etc...).
Note that this includes windows.h in Win, which can be a bit of an issue since we are header only. => this is only a problem in Win when using the C++ interface and not compiling with C++17.
Check C-Interface of ModelPart, there some things are not yet clear => @pooyan-dadvand
do we need identifier for Import/Export of Info and ModelPart? => add it everywhere => detail: what about the name of the ModelPart? Probably doesn't matter... => Using identifier #123 (always using identifier)
maybe call the sync-file xxx.sync => then might be clearer. (In the future this has to probably be split into connect & disconnect, bcs during the connection phase more info is exchanged (e.g. number of cores the "other" code runs with), but during the disconnect phase it is only needed for syncing)
How to copy connection_name in C? => use strcpy (probably in combination with BUFSIZ => should we then limit length of names to prevent overflow?) => using strcpy #124
Documentation
go through tutorial and improve if necessary
Complete the API-documentation
C++
C
Python
enhance the Python-interface to give the full docs in the interface (e.g. __doc__)
Document the settings used for each IO method. In the error message when setting is invalid or empty?
Unit Testing
Possible solutions:
-T memcheck
)inline
definitions are there => Missing inline and test #78Functionalities
connection_name
to make usage easier (probably intoname
andconnection_partner
=> consider that this has to be given to all the functions. Or maybe return aconnection_name
that should be used in further calls?) => Improve connect interface #65Import
/Export
with objects (e.g.Mesh
for enhanced functionalities)Run
method => Bringing back the Run method #134Info
to Python => Expose Info copy ctor to python #79Info
available in C => [C] copy Info #132std::vector
) => [Python] adding Vector #118ModelPart
available in C => [C][ModelPart] finished implementation #131Internal
implement=> will not be done as too much effort for too little usagebegin
&end
inDataContainer
to make them usable in range-based loopssolver
/software-tool
/code
/ (process
))std::filesystem
. I think it will be worth it and reduce many problematic caseswindows.h
in Win, which can be a bit of an issue since we are header only. => this is only a problem in Win when using the C++ interface and not compiling with C++17.ModelPart
, there some things are not yet clear => @pooyan-dadvandidentifier
for Import/Export ofInfo
andModelPart
? => add it everywhere => detail: what about the name of the ModelPart? Probably doesn't matter... => Using identifier #123 (always usingidentifier
)xxx.sync
=> then might be clearer. (In the future this has to probably be split into connect & disconnect, bcs during the connection phase more info is exchanged (e.g. number of cores the "other" code runs with), but during the disconnect phase it is only needed for syncing)Documentation
__doc__
)The text was updated successfully, but these errors were encountered: