Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap Release 2.0 #55

Closed
34 of 35 tasks
philbucher opened this issue May 18, 2020 · 2 comments
Closed
34 of 35 tasks

Roadmap Release 2.0 #55

philbucher opened this issue May 18, 2020 · 2 comments
Labels
enhancement New feature or request todo

Comments

@philbucher
Copy link
Member

philbucher commented May 18, 2020

Unit Testing

Functionalities

Internal

  • implement begin & end in DataContainer to make them usable in range-based loops => will not be done as too much effort for too little usage
  • implement proper connect for FileComm
  • improve error macro such that it behaves like the one in Kratos => Improve CO_SIM_IO_ERROR #92
  • agree on naming convention (solver / software-tool / code / (process))
  • since it is very unlikely that we move to C++17 I would seriously consider including the C++11 version of std::filesystem. I think it will be worth it and reduce many problematic cases
    • Otherwise many things become much more difficult (e.g. deadlocks bcs of leftover files from previous runs etc...).
    • Note that this includes windows.h in Win, which can be a bit of an issue since we are header only. => this is only a problem in Win when using the C++ interface and not compiling with C++17.
  • investigate why Win CI sometimes timeouts, maybe related to new Connection of FileComm. Check how long the codes wait. => Improve file access concurrency issues #139 should hopefully solve this (also related: reduce wait time in FileCommunication #133)
  • Check C-Interface of ModelPart, there some things are not yet clear => @pooyan-dadvand
  • do we need identifier for Import/Export of Info and ModelPart? => add it everywhere => detail: what about the name of the ModelPart? Probably doesn't matter... => Using identifier #123 (always using identifier)
  • maybe call the sync-file xxx.sync => then might be clearer. (In the future this has to probably be split into connect & disconnect, bcs during the connection phase more info is exchanged (e.g. number of cores the "other" code runs with), but during the disconnect phase it is only needed for syncing)
  • How to copy connection_name in C? => use strcpy (probably in combination with BUFSIZ => should we then limit length of names to prevent overflow?) => using strcpy #124

Documentation

@philbucher philbucher added the enhancement New feature or request label May 18, 2020
@philbucher philbucher mentioned this issue May 19, 2020
22 tasks
@pooyan-dadvand
Copy link
Member

Maybe we can have a new import/export modelpart instead of enhancing the mesh one with additional object

@philbucher philbucher changed the title Roadmap Release 2 Roadmap Release 2.0 Jan 13, 2021
@philbucher
Copy link
Member Author

remaining things will be addressed for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request todo
Projects
None yet
Development

No branches or pull requests

2 participants