Publish Segment.size and Segment.remainingCapacity #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhinkin
commented
Oct 30, 2024
| * | ||
| * @sample kotlinx.io.samples.unsafe.UnsafeBufferOperationsSamples.readUleb128 | ||
| */ | ||
| public val size: Int |
There was a problem hiding this comment.
Perhaps, it should be Long.
There was a problem hiding this comment.
But then both pos and limit have to be updated too.
There was a problem hiding this comment.
The main issue here that these properties already leaked into users' projects, like Ktor.
There was a problem hiding this comment.
And the reason why we might need Long properties here is supporting MemorySegmented backed segments on JVM (and that's nowhere near).
There was a problem hiding this comment.
MemorySegments can be sliced which should be a cheap operation. If one came in over 2^31 in length, it could be sliced into multiple segments.
qwwdfsad
approved these changes
Oct 31, 2024
shanshin
approved these changes
Nov 4, 2024
Egorand
added a commit
to Egorand/kotlinx-io
that referenced
this pull request
Nov 14, 2024
* 'develop' of github.com:Kotlin/kotlinx-io: Publish Segment.size and Segment.remainingCapacity (Kotlin#409) Generate JPMS modules (Kotlin#406) Document empty bytestring factory (Kotlin#396) Update error message in `writableSegment` (Kotlin#398) Improve documentation (Kotlin#395)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408