Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate JPMS modules #406

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Generate JPMS modules #406

merged 2 commits into from
Oct 21, 2024

Conversation

fzhinkin
Copy link
Collaborator

Generate JMPS modules for both bytestring and core modules.

The code harnessing compilations setup is inspired by taken from https://github.com/JetBrains/kotlin/blob/master/repo/gradle-build-conventions/buildsrc-compat/src/main/kotlin/LibrariesCommon.kt.

Closes #401

Java modules could not be easily mixed with "regular" multi-release compilation,
so all previously added code was specialized for modules ony.
@fzhinkin fzhinkin linked an issue Oct 18, 2024 that may be closed by this pull request
@fzhinkin fzhinkin requested a review from shanshin October 18, 2024 15:37
@fzhinkin fzhinkin merged commit fa3afc3 into develop Oct 21, 2024
1 check passed
@fzhinkin fzhinkin deleted the 401-java-modules-support branch October 21, 2024 14:15
Egorand added a commit to Egorand/kotlinx-io that referenced this pull request Nov 14, 2024
* 'develop' of github.com:Kotlin/kotlinx-io:
  Publish Segment.size and Segment.remainingCapacity (Kotlin#409)
  Generate JPMS modules (Kotlin#406)
  Document empty bytestring factory (Kotlin#396)
  Update error message in `writableSegment` (Kotlin#398)
  Improve documentation (Kotlin#395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java module not found: kotlinx.io.core.jvm
2 participants