Fix #333 Close HTTP connections #334
Conversation
| val client = createHttpClient() | ||
| val response = client(request) | ||
|
|
||
| return ResponseWrapper(response, request.uri.toString()) | ||
| return ResponseWrapper(response, request.uri.toString()).use(mapper) |
There was a problem hiding this comment.
Won't it fix the issue if we just close the response here? I mean
val client = createHttpClient()
val response = client(request)
response.close()
return ResponseWrapper(response, request.uri.toString())
There was a problem hiding this comment.
The connection will be closed of course, but I'm afraid that if you try to access the request's body after that, you'll get an exception
There was a problem hiding this comment.
Actually, it seems that closing the response doesn't help at this point. The returned response object is a MemoryResponse, so closing it is a no-op. The HTTP connection is probably expected to be closed in CloseableHttpResponse.toHttp4kResponse which consumes the entire payload, but again, that doesn't happen in our AWS setup.
There was a problem hiding this comment.
@strangepleasures have you checked that the edits you have introduced fix the issue in your AWS setup?
There was a problem hiding this comment.
I can provide you with pip package if you need
There was a problem hiding this comment.
ApacheClient() without arguments creates a client with a PoolingHttpClientConnectionManager with infinite TTL. Maybe, that's why connections never get closed.
ileasile
force-pushed
the
fix_leaking_http_connections
branch
from
970b399 to
80e9103
Compare
No description provided.