Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking HTTP connections #333

Closed
strangepleasures opened this issue Sep 22, 2021 · 0 comments
Closed

Leaking HTTP connections #333

strangepleasures opened this issue Sep 22, 2021 · 0 comments

Comments

@strangepleasures
Copy link
Contributor

strangepleasures commented Sep 22, 2021 •
edited
Loading

There's a lot of places in the code where HTTP(S) requests are made using getHttp.
Contrarily to the common best practice, HTTP connections are never closed explicitly.
They might get closed by the system at some point, but that somehow never happens in our AWS setup.
(May be OS/JVM/settings-dependent).
strangepleasures added a commit to strangepleasures/kotlin-jupyter that referenced this issue Sep 22, 2021
@strangepleasures
Fix Kotlin#333 Close HTTP connections
b7f5320
ileasile pushed a commit to strangepleasures/kotlin-jupyter that referenced this issue Sep 27, 2021
@strangepleasures @ileasile
Fix Kotlin#333 Close HTTP connections
9f9fa05
strangepleasures added a commit to strangepleasures/kotlin-jupyter that referenced this issue Sep 27, 2021
@strangepleasures
Fix Kotlin#333, Close HTTP clients
27066b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@strangepleasures