Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Cassandra-backed Kong #974

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Remove support for Cassandra-backed Kong #974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/ingress-controller/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,8 @@ func main() {
controllerConfig.Kong.InMemory = true
}
if kongDB == "cassandra" {
log.Warn("running controller with kong cassandra as a datastore is deprecated; " +
"please consider using postgres or in-memory mode")
log.Fatalf("Cassandra-backed deployments of Kong managed by the ingress controller are no longer supported;" +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: all errors should start with lower case letter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine here--guidance is that it's fine if the leading word is a proper noun, and Cassandra is: https://github.com/golang/go/wiki/CodeReviewComments#error-strings

"you must migrate to a Postgres-backed or DB-less deployment")
}

req, _ := http.NewRequest("GET",
Expand Down