Remove support for Cassandra-backed Kong #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbagdi
approved these changes
Dec 7, 2020
| @@ -282,8 +282,8 @@ func main() { | |||
| controllerConfig.Kong.InMemory = true | |||
| } | |||
| if kongDB == "cassandra" { | |||
| log.Warn("running controller with kong cassandra as a datastore is deprecated; " + | |||
| "please consider using postgres or in-memory mode") | |||
| log.Fatalf("Cassandra-backed deployments of Kong managed by the ingress controller are no longer supported;" + | |||
There was a problem hiding this comment.
Nit: all errors should start with lower case letter.
There was a problem hiding this comment.
Should be fine here--guidance is that it's fine if the leading word is a proper noun, and Cassandra is: https://github.com/golang/go/wiki/CodeReviewComments#error-strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cassandra-backed Kong instance support is going away in 1.1.0 after being deprecated in 0.9.0. This replaces the deprecation warning with a fatal error
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #968