Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new cli parsing and environment variable #436

Merged
merged 2 commits into from
Oct 29, 2019
Merged

feat: new cli parsing and environment variable #436

merged 2 commits into from
Oct 29, 2019

Commits on Oct 23, 2019

  1. feat(cli) implement environment variable based configuration 

    In addition to CLI based configuration, environment variables can now be
used to configure the Ingress Controller.
All env vars are prefixed with `CONTROLLER_`, followed by the name of
the CLI flag (`-` converted to `_`).

The configuration is parsed into an intermediate struct and then later a
subset is passed down to the controller config. This is a change to make
split out controller and make it unit-testable in future, an effort
on-going since last few releases.
    @hbagdi
    hbagdi committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    1a83afc View commit details
    Browse the repository at this point in the history

  2. feat(cli) introduce new CLI flags and deprecate old ones 

    Breaking change deprecations
----------------------------

The following CLI flags are marked as deprecated and will be removed in
a future release:
- `--kong-url`
- `--admin-tls-skip-verify`
- `--admin-header`
- `--admin-tls-server-name`
- `--admin-ca-cert-file`

New replacements have been added, please see `--help` for more details.
    @hbagdi
    hbagdi committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    681d5dc View commit details
    Browse the repository at this point in the history