feat: new cli parsing and environment variable #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to CLI based configuration, environment variables can now be used to configure the Ingress Controller. All env vars are prefixed with `CONTROLLER_`, followed by the name of the CLI flag (`-` converted to `_`). The configuration is parsed into an intermediate struct and then later a subset is passed down to the controller config. This is a change to make split out controller and make it unit-testable in future, an effort on-going since last few releases.
Breaking change deprecations ---------------------------- The following CLI flags are marked as deprecated and will be removed in a future release: - `--kong-url` - `--admin-tls-skip-verify` - `--admin-header` - `--admin-tls-server-name` - `--admin-ca-cert-file` New replacements have been added, please see `--help` for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Revamps the CLI configuration and flags of the controller.
The controller can now be configured using environment variables and certain flags are marked as deprecated.
This also enables users to use k8s secrets for sensitive values like authentication header to use against Kong's Admin API, which had to be stored in plain-text previously.