Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: info instead of warn for no targets #2825

Merged
merged 1 commit into from
Aug 16, 2022
Merged

fix: info instead of warn for no targets #2825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,11 @@
#### Fixed

- When `Endpoints` could not be found for a `Service` to add them as targets of
a Kong `Upstream`, this was producing a log message at `error` level which was
inaccurate because this condition is often expected when `Pods` are being
provisioned. Those log entries now report at `info` level.
a Kong `Upstream`, this would produce a log message at `error` and `warning`
levels which was inaccurate because this condition is often expected when
`Pods` are being provisioned. Those log entries now report at `info` level.
[#2820](https://github.com/Kong/kubernetes-ingress-controller/issues/2820)
[#2825](https://github.com/Kong/kubernetes-ingress-controller/pull/2825)
- Added `mtls-auth` to the admission webhook supported credential types list.
[#2739](https://github.com/Kong/kubernetes-ingress-controller/pull/2739)
- Disabled additional IngressClass lookups in other reconcilers when the
Expand Down
2 changes: 1 addition & 1 deletion internal/dataplane/parser/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ func getUpstreams(

// warn if an upstream was created with 0 targets
if len(targets) == 0 {
log.WithField("service_name", *service.Name).Warnf("no targets found to create upstream")
log.WithField("service_name", *service.Name).Infof("no targets found to create upstream")
}

// define the upstream including all the newly populated targets
Expand Down