Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: info instead of warn for no targets #2825

Merged
merged 1 commit into from
Aug 16, 2022
Merged

fix: info instead of warn for no targets #2825

merged 1 commit into from
Aug 16, 2022

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Aug 16, 2022

What this PR does / why we need it:

This turns a previous warning log about targets not being available for an upstream into an info log, as this condition is expected any time there are pods in flight.

Which issue this PR fixes:

Resolves #2820

PR Readiness Checklist:

  • the CHANGELOG.md release notes have been updated

@shaneutt shaneutt added the bug Something isn't working label Aug 16, 2022
@shaneutt shaneutt added this to the Release v2.6.0 milestone Aug 16, 2022
@shaneutt shaneutt self-assigned this Aug 16, 2022
@shaneutt shaneutt temporarily deployed to Configure ci August 16, 2022 13:55 Inactive
@shaneutt shaneutt marked this pull request as ready for review August 16, 2022 13:55
@shaneutt shaneutt requested a review from a team as a code owner August 16, 2022 13:55
@shaneutt shaneutt enabled auto-merge (rebase) August 16, 2022 13:55
@shaneutt shaneutt merged commit f5fd744 into main Aug 16, 2022
@shaneutt shaneutt temporarily deployed to Configure ci August 16, 2022 14:19 Inactive
@shaneutt shaneutt deleted the shaneutt/2820p2 branch August 16, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller logs absence of ready Endpoints addresses as an error
3 participants