Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPRoute conformance tests #2737

Merged
merged 3 commits into from
Aug 12, 2022
Merged

HTTPRoute conformance tests #2737

merged 3 commits into from
Aug 12, 2022

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Jul 25, 2022

What this PR does / why we need it:

Which issue this PR fixes:
Fixes #2776

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

github-actions[bot]
github-actions bot previously approved these changes Aug 2, 2022
@mlavacca mlavacca requested a review from pmalek August 11, 2022 15:15
@mlavacca mlavacca temporarily deployed to Configure ci August 11, 2022 15:39 Inactive
internal/util/conversions.go Outdated Show resolved Hide resolved
internal/util/conversions.go Outdated Show resolved Hide resolved
All the core conformance tests for the Gateway API successfully run.
Besides, also the optional ReferenceGrant-related tests have been added
to the suite and run with success.

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
internal/util/k8s.go Outdated Show resolved Hide resolved
internal/util/k8s.go Outdated Show resolved Hide resolved
internal/dataplane/parser/translate_httproute.go Outdated Show resolved Hide resolved
@mlavacca mlavacca temporarily deployed to Configure ci August 12, 2022 07:44 Inactive
@mlavacca mlavacca requested a review from pmalek August 12, 2022 07:44
@mlavacca mlavacca temporarily deployed to Configure ci August 12, 2022 07:50 Inactive
internal/util/k8s.go Outdated Show resolved Hide resolved
@mlavacca mlavacca temporarily deployed to Configure ci August 12, 2022 08:19 Inactive
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca temporarily deployed to Configure ci August 12, 2022 10:23 Inactive
@mlavacca mlavacca requested a review from pmalek August 12, 2022 10:24
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 but I'd let others chip in as well. Merge at your own convenience :)

@mlavacca mlavacca temporarily deployed to Configure ci August 12, 2022 10:47 Inactive
@mlavacca mlavacca merged commit 217e4c4 into main Aug 12, 2022
@mlavacca mlavacca deleted the conformance-tests branch August 12, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all conformance tests for v1beta1.HTTPRoute are run and required for every PR
3 participants