Skip to content

Commit

Permalink
httproute tests working
Browse files Browse the repository at this point in the history
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
  • Loading branch information
mlavacca committed Jul 26, 2022
1 parent a87c1e6 commit 0fdea4e
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 7 deletions.
2 changes: 2 additions & 0 deletions internal/dataplane/parser/translate_httproute.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ func generateKongRoutesFromHTTPRouteRule(httproute *gatewayv1alpha2.HTTPRoute, r
r.Route.Headers = headers
}

r.StripPath = kong.Bool(false)

// add the route to the list of routes for the service(s)
routes = append(routes, r)
}
Expand Down
24 changes: 17 additions & 7 deletions test/conformance/gateway_conformance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,21 @@ func TestGatewayConformance(t *testing.T) {
// TODO: ensure that this module runs all Gateway conformance tests
// https://github.com/Kong/kubernetes-ingress-controller/issues/2210
var enabledGatewayConformanceTests = sets.NewString(
//"HTTPRouteCrossNamespace",
// "HTTPRouteInvalidCrossNamespace" is the last one we need to get working
// before we can delete this set and simply run ALL, but requires:
// https://github.com/Kong/kubernetes-ingress-controller/issues/2080
//"HTTPRouteMatchingAcrossRoutes",
//"HTTPRouteMatching",
"HTTPRouteSimpleSameNamespace",
// "HTTPRouteCrossNamespace", //OK
// "HTTPRouteDisallowedKind", //OK
// "HTTPExactPathMatching", //OK
// "HTTPRouteHeaderMatching", //OK
// "HTTPRouteHostnameIntersection", //FAIL
// "HTTPRouteInvalidNonExistentBackendRef",
// "HTTPRouteInvalidBackendRefUnknownKind"
// "HTTPRouteInvalidCrossNamespaceBackendRef",
// "HTTPRouteInvalidCrossNamespaceParentRef",
// "HTTPRouteInvalidReferenceGrant",
// "HTTPRouteListenerHostnameMatching",
// "HTTPRouteMatchingAcrossRoutes", //OK
// "HTTPRouteMatching", //OK
// "HTTPRouteQueryParamMatching",
// "HTTPRouteReferenceGrant",
// "HTTPRouteRequestHeaderModifier",
// "HTTPRouteSimpleSameNamespace", //OK
)

0 comments on commit 0fdea4e

Please sign in to comment.