Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: path only based routing #190

Merged
merged 1 commit into from
Nov 6, 2018
Merged

fix: path only based routing #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions internal/ingress/controller/kong.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@ func (n *NGINXController) OnUpdate(ingressCfg *ingress.Configuration) error {
}

for _, server := range ingressCfg.Servers {
if server.Hostname == "_" {
// there is no catch all server in kong
continue
}

err := n.syncUpstreams(server.Locations, ingressCfg.Backends)
if err != nil {
Expand Down Expand Up @@ -315,10 +311,6 @@ func (n *NGINXController) syncServices(ingressCfg *ingress.Configuration) (bool,

// Check if the endpoints exists as a service in kong
for _, server := range ingressCfg.Servers {
if server.Hostname == "_" {
// there is no catch all server in kong
continue
}

for _, location := range server.Locations {
backend := location.Backend
Expand Down Expand Up @@ -942,10 +934,6 @@ func (n *NGINXController) syncUpstreams(locations []*ingress.Location, backends

for _, location := range locations {
backend := location.Backend
if backend == "default-backend" {
// there is no default backend in Kong
continue
}

ingress := location.Ingress
if ingress == nil {
Expand Down