fix: path only based routing #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc3a19b introduced path only based routing but introduced a bug in the code. If there exist only path based routing rules for a service, then the ingress will never be satisfied. There was at least one host based ingress rule necessary to satisfied other host-less ingress rules for any service. This commit fixes that and properly creates routing rules in Kong to satisfy path-only ingress rules.
hbagdi
added a commit
that referenced
this pull request
Nov 8, 2018
dc3a19b introduced path only based routing but introduced a bug in the code. If there exist only path based routing rules for a service, then the ingress will never be satisfied. There was at least one host based ingress rule necessary to satisfied other host-less ingress rules for any service. This commit fixes that and properly creates routing rules in Kong to satisfy path-only ingress rules. From #190
hbagdi
added a commit
that referenced
this pull request
Nov 8, 2018
dc3a19b introduced path only based routing but introduced a bug in the code. If there exist only path based routing rules for a service, then the ingress will never be satisfied. There was at least one host based ingress rule necessary to satisfied other host-less ingress rules for any service. This commit fixes that and properly creates routing rules in Kong to satisfy path-only ingress rules. From #190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dc3a19b introduced path only based routing but introduced a bug in the
code.
If there exist only path based routing rules for a service, then
the ingress will never be satisfied. There was at least one host based
ingress rule necessary to satisfied other host-less ingress rules for
any service.
This commit fixes that and properly creates routing rules in Kong to
satisfy path-only ingress rules.