Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Infer appropriate Kong route snis value from Ingress contents automat… #1841

Closed
wants to merge 6 commits into from

Conversation

ccfishk
Copy link
Contributor

@ccfishk ccfishk commented Sep 20, 2021

What this PR does / why we need it:

Kong/kong#6425 is fixed. KIC is able to fill in SNI(s) of routes object automatically

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

#929
KIC fills in routes SNIs automatically according to ingress TLS hosts setup

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@github-actions
Copy link

Licenses differ between commit 6431485 and base:

+++ pr_licenses.csv	2021-09-20 15:19:37.560770626 +0000
@@ -76,8 +76,7 @@
 gopkg.in/yaml.v3,Unknown,MIT
 k8s.io/api,Unknown,Apache-2.0
 k8s.io/apiextensions-apiserver/pkg/apis/apiextensions,Unknown,Apache-2.0
-k8s.io/apimachinery/pkg,Unknown,Apache-2.0
-k8s.io/apimachinery/third_party/forked/golang,Unknown,BSD-3-Clause
+k8s.io/apimachinery,Unknown,Apache-2.0
 k8s.io/client-go,Unknown,Apache-2.0
 k8s.io/component-base/config,Unknown,Apache-2.0
 k8s.io/klog/v2,Unknown,Apache-2.0```

@ccfishk ccfishk self-assigned this Sep 20, 2021
@ccfishk ccfishk changed the title Infer appropriate Kong route snis value from Ingress contents automat… [WIP] Infer appropriate Kong route snis value from Ingress contents automat… Sep 20, 2021
Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this change tested?

@ccfishk
Copy link
Contributor Author

ccfishk commented Sep 22, 2021

How was this change tested?

Have been baking an integration test case - verifying that the SNI parameter of the created routes is functional

  1. Create a Service with a route A
  2. Specify hostnames
  3. Expect this PR fill in SNI(s automatically)
  4. Send an HTTP request to Route A, with the correct hostname, e.g. curl -sv localhost:8000/ -H "Host: sni.kong.example”.
  5. Verify returns 200

@ccfishk ccfishk temporarily deployed to Configure ci September 22, 2021 21:49 Inactive
@mflendrich
Copy link
Contributor

Let's start from here when we pick this change up for implementation again.

@mflendrich mflendrich closed this Oct 12, 2021
@shaneutt shaneutt deleted the info-sni branch October 27, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants