-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Infer appropriate Kong route snis value from Ingress contents automat… #1841
Conversation
Licenses differ between commit 6431485 and base:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was this change tested?
Have been baking an integration test case - verifying that the SNI parameter of the created routes is functional
|
Let's start from here when we pick this change up for implementation again. |
What this PR does / why we need it:
Kong/kong#6425 is fixed. KIC is able to fill in SNI(s) of routes object automatically
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes ##929
KIC fills in routes SNIs automatically according to ingress TLS hosts setup
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR