Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer appropriate Kong route snis value from Ingress contents automatically #929

Closed
2 tasks
rainest opened this issue Oct 29, 2020 · 4 comments
Closed
2 tasks
Labels

Comments

@rainest
Copy link
Contributor

rainest commented Oct 29, 2020

As a user I'd like KIC to fill in the snis field of a created route from the context of the ingress resource, so that the user does not need to specify the SNIs manually.

Historical context (the root cause for this not having been implemented back then seems to be resolved now):

Draft feature request to restore the automatic route snis population removed from #863.

We should revisit this once Kong/kong#6425 is fixed. However, the exact shape of this feature will depend on that fix, so for now this is a stub feature request with the original automation code for reference. That code "works" in the Kong <=2.2 world, but the effects of it working are bad. As such, we shouldn't actually develop any such automation for those versions.

Once we have new Kong router SNI behavior to work against, we should also add an E2E test, as testing this sort of automation effectively with Go tests alone probably isn't possible: it's very dependent on interactions with the Kong proxy vis a vis user expectations, and unit tests can't express either of those things.

Acceptance criteria

  • for an HTTPS ingress configuration, KIC fills in the snis of a created route.
  • integration tests for the SNI case are implemented (verifying that the SNI parameter of the created routes is functional)
@rainest rainest added the area/feature New feature or request label Oct 29, 2020
@rainest
Copy link
Contributor Author

rainest commented Oct 29, 2020

git-show of the old commented code: auto-sni.diff.txt

It's a diff, but Github has asinine rules about allowed file extensions because MIME-sniffing is impossible, so it's a .txt.

@stale
Copy link

stale bot commented Mar 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Will be closed unless advocated for within 7 days label Mar 20, 2021
@rainest rainest added pinned and removed stale Will be closed unless advocated for within 7 days labels Mar 22, 2021
@mflendrich mflendrich removed the pinned label Mar 31, 2021
@mflendrich
Copy link
Contributor

Recent versions of core are capable of supporting these inferred values.
The implementation would need to be a no-op for older versions of Kong (@rainest says 2.2.1 is the first version that can support this).

@shaneutt
Copy link
Contributor

Closing as stale since the last comments are almost a year old. If there's still interest in following up on this however lets re-open/re-assess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants