Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] v1beta1.UDPIngress API #1454

Merged
merged 13 commits into from
Jun 23, 2021
Merged

[Feature] v1beta1.UDPIngress API #1454

merged 13 commits into from
Jun 23, 2021

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Jun 23, 2021

What this PR does / why we need it:

This PR adds support for UDP protocol functionality by adding a new v1beta1.UDPIngress API.

Which issue this PR fixes

fixes #1080
fixes #1081

PR Readiness Checklist:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR
  • Integration test fixes #1453 resolved first

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #1454 (43da47a) into next (6a2cb60) will decrease coverage by 0.11%.
The diff coverage is 30.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1454      +/-   ##
==========================================
- Coverage   55.99%   55.87%   -0.12%     
==========================================
  Files          43       44       +1     
  Lines        3704     3733      +29     
==========================================
+ Hits         2074     2086      +12     
- Misses       1481     1499      +18     
+ Partials      149      148       -1     
Impacted Files Coverage Δ
pkg/parser/translate.go 81.81% <0.00%> (-4.12%) ⬇️
pkg/store/fake_store.go 68.83% <ø> (ø)
pkg/store/store.go 32.11% <0.00%> (ø)
pkg/parser/parser.go 84.51% <88.88%> (+1.68%) ⬆️
pkg/util/networking.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2cb60...43da47a. Read the comment docs.

@shaneutt shaneutt force-pushed the integration-test-fixes branch 3 times, most recently from ad2a200 to 0e94e61 Compare June 23, 2021 19:07
Base automatically changed from integration-test-fixes to next June 23, 2021 19:58
@shaneutt shaneutt temporarily deployed to Configure ci June 23, 2021 20:01 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci June 23, 2021 20:01 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci June 23, 2021 20:40 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci June 23, 2021 20:40 Inactive
@shaneutt shaneutt marked this pull request as ready for review June 23, 2021 20:41
@shaneutt shaneutt requested a review from a team as a code owner June 23, 2021 20:41
@shaneutt shaneutt merged commit 87a3ed0 into next Jun 23, 2021
@shaneutt shaneutt deleted the udpingress branch June 23, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants