Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple rules in UDPIngress #1081

Closed
rainest opened this issue Mar 5, 2021 · 1 comment
Closed

Support for multiple rules in UDPIngress #1081

rainest opened this issue Mar 5, 2021 · 1 comment
Assignees
Labels

Comments

@rainest
Copy link
Contributor

rainest commented Mar 5, 2021

The v1alpha1 UDPIngress supports a single rule only, represented by the entire spec:

spec:
  host: "9.9.9.9"
  targetPort: 53
  listenPort: 9999

Other Ingress-likes (e.g. below our TCPIngress type) support multiple rules, which can target different Services:

spec:
  rules:
  - host: <SNI, optional>
    port: <port on which to expose this service, required>
    backend:
      serviceName: <name of the kubernetes service, required>
      servicePort: <port number to forward on the service, required>

The same is true for the Gateway TCPRoute spec. UDPRoute would presumably be similar.

 func fromUDPIngressV1Alpha1(log logrus.FieldLogger, ingressList []*v1alpha1.UDPIngress) ingressRules {
		result.ServiceNameToServices[ingress.Namespace+"."+ingress.Name] = kongstate.Service{
			Service: kong.Service{
				Name:     kong.String(ingress.Namespace + "." + ingress.Name),

See also: #1080

@rainest rainest added this to the UDP Ingress Support milestone Mar 5, 2021
@stale
Copy link

stale bot commented Mar 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Will be closed unless advocated for within 7 days label Mar 20, 2021
@rainest rainest added pinned and removed stale Will be closed unless advocated for within 7 days labels Mar 22, 2021
@shaneutt shaneutt added priority/high area/feature New feature or request labels Mar 25, 2021
@mflendrich mflendrich removed the pinned label Mar 31, 2021
@shaneutt shaneutt self-assigned this Jun 1, 2021
@shaneutt shaneutt linked a pull request Jun 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants