Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kong Enterprise version with dash #141

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Fix Kong Enterprise version with dash #141

merged 2 commits into from
Sep 26, 2018

Conversation

fffonion
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 25, 2018 •
edited
Loading

Codecov Report

Merging #141 into master will decrease coverage by 5.24%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   31.66%   26.41%   -5.25%     
==========================================
  Files          33       46      +13     
  Lines        2956     3585     +629     
==========================================
+ Hits          936      947      +11     
- Misses       1906     2524     +618     
  Partials      114      114
Impacted Files Coverage Δ
internal/apis/admin/kong_client.go 11.11% <91.66%> (ø)
internal/apis/admin/credential.go 0% <0%> (ø)
internal/apis/admin/service.go 0% <0%> (ø)
internal/apis/admin/plugin.go 0% <0%> (ø)
internal/apis/admin/certificate.go 0% <0%> (ø)
internal/apis/admin/admin_wrapper.go 0% <0%> (ø)
internal/apis/admin/api_helper.go 0% <0%> (ø)
internal/apis/admin/sni.go 0% <0%> (ø)
internal/apis/admin/consumer.go 0% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9e38c...8b5d633. Read the comment docs.

@hbagdi
Copy link
Member

hbagdi commented Sep 25, 2018

@fffonion Please open this fix against our master branch.
Once merged, it can be cherry-picked to 0.1.x

@hbagdi hbagdi mentioned this pull request Sep 25, 2018
Closed
@fffonion fffonion changed the base branch from v0.1.x to master September 25, 2018 23:53
@hbagdi hbagdi merged commit 4f3a244 into master Sep 26, 2018
@hbagdi hbagdi deleted the fix/ee-versioning branch September 26, 2018 02:14
hbagdi pushed a commit that referenced this pull request Sep 26, 2018
@fffonion @hbagdi
fix(admin) handle minor number versioning scheme for Kong Enterprise
345cb96 
Kong Enterprise follows a version scheme
of `x.y-z` while Kong follow `x.y.z`.
Both products have an `rc` or other meta
appended without a `-`, which makes
semver unhappy.

For #141
@hbagdi hbagdi mentioned this pull request Sep 26, 2018
Merged
hbagdi added a commit that referenced this pull request Sep 26, 2018
@hbagdi
fix(admin) handle minor number versioning scheme for Kong Enterprise
b768275 
Kong Enterprise follows a version scheme
of `x.y-z` while Kong follow `x.y.z`.
Both products have an `rc` or other meta
appended without a `-`, which makes
semver unhappy.

For #141 
From #144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbagdi hbagdi hbagdi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fffonion @codecov-io @hbagdi