-
Notifications
You must be signed in to change notification settings - Fork 590
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(admin) handle minor number versioning scheme for Kong Enterprise
Kong Enterprise follows a version scheme of `x.y-z` while Kong follow `x.y.z`. Both products have an `rc` or other meta appended without a `-`, which makes semver unhappy. For #141 From #144
- Loading branch information
Showing
2 changed files
with
59 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package admin | ||
|
||
import ( | ||
"testing" | ||
) | ||
|
||
func TestFixVersion(t *testing.T) { | ||
validVersions := map[string]string{ | ||
"0.14.1": "0.14.1", | ||
"0.14.2rc": "0.14.2-rc", | ||
"0.14.2rc1": "0.14.2-rc1", | ||
"0.14.2preview": "0.14.2-preview", | ||
"0.14.2preview1": "0.14.2-preview1", | ||
"0.33-enterprise-edition": "0.33.0-enterprise", | ||
"0.33-1-enterprise-edition": "0.33.1-enterprise", | ||
} | ||
for inputVersion, expectedVersion := range validVersions { | ||
v, err := fixVersion(inputVersion) | ||
if err != nil { | ||
t.Errorf("error converting %s: %v", inputVersion, err) | ||
} else if v.String() != expectedVersion { | ||
t.Errorf("converting %s, expecting %s, getting %s", inputVersion, expectedVersion, v.String()) | ||
} | ||
} | ||
|
||
invalidVersions := []string{ | ||
"", | ||
"0-1-1", | ||
} | ||
for _, inputVersion := range invalidVersions { | ||
_, err := fixVersion(inputVersion) | ||
if err == nil { | ||
t.Errorf("expecting error converting %s, getting no errors", inputVersion) | ||
} | ||
} | ||
|
||
return | ||
} |