Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new plugins anns #124

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Feat/new plugins anns #124

merged 2 commits into from
Sep 12, 2018

Commits on Sep 11, 2018

  1. feat: introduce a helper method to parse plugins.konghq.com annotat…

    …ions
    
    Currently, plugins in Kong are configured using the following
    annotation: `key-auth.plugin.konghq.com: <name of KongPlugin CR>`.
    
    This works fine but decouples the configuration of a plugin from the
    name of the plugin to which that configuration should be applied to.
    In practise, it rarely happens that plugin configs are reusable across
    different types/kinds (key-auth, rate-limiting etc) of plugins.
    
    This change introduces a method to parse an annotation of the form
    `plugins.konghq.com`, which allow you to specify KongPlugin Custom
    Resources(CR) as a CSV, which can be applied to an entity in Kong (route
    or service or consumer).
    hbagdi committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    bf85413 View commit details
    Browse the repository at this point in the history
  2. feat: allow configuring KongPlugins using plugins.konghq.com

    This change allows an end-user to configure a plugin on a route or a
    service in Kong using a new annotaion: `plugins.konghq.com`.
    This annotations should contain a CSV list of KongPlugin CR names which
    should be applied.
    
    This should make it easier for the end user to configure plugins on
    Ingress resources and k8s Services.
    
    The old way of configuration plugins:
    `<plugin-name>.plugin.konghq.com: <KongPlugin CR name>`
    is deprecated but still supported, giving users time to migrate to new
    annotations. There will be a documentation commit made in future to
    reflect the same.
    hbagdi committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    30687be View commit details
    Browse the repository at this point in the history