Feat/new plugins anns #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 31.46% 31.68% +0.22%
==========================================
Files 33 33
Lines 2937 2954 +17
==========================================
+ Hits 924 936 +12
- Misses 1900 1904 +4
- Partials 113 114 +1
Continue to review full report at Codecov.
|
fffonion
reviewed
Sep 11, 2018
fffonion
reviewed
Sep 11, 2018
…ions Currently, plugins in Kong are configured using the following annotation: `key-auth.plugin.konghq.com: <name of KongPlugin CR>`. This works fine but decouples the configuration of a plugin from the name of the plugin to which that configuration should be applied to. In practise, it rarely happens that plugin configs are reusable across different types/kinds (key-auth, rate-limiting etc) of plugins. This change introduces a method to parse an annotation of the form `plugins.konghq.com`, which allow you to specify KongPlugin Custom Resources(CR) as a CSV, which can be applied to an entity in Kong (route or service or consumer).
This change allows an end-user to configure a plugin on a route or a service in Kong using a new annotaion: `plugins.konghq.com`. This annotations should contain a CSV list of KongPlugin CR names which should be applied. This should make it easier for the end user to configure plugins on Ingress resources and k8s Services. The old way of configuration plugins: `<plugin-name>.plugin.konghq.com: <KongPlugin CR name>` is deprecated but still supported, giving users time to migrate to new annotations. There will be a documentation commit made in future to reflect the same.
hbagdi
force-pushed
the
feat/new-plugins-anns
branch
from
ddae418
to
30687be
Compare
|
Thanks for the review @fffonion! |
fffonion
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring plugins in Kong using
plugins.konghq.comannotation, making it user friendly.