-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing schema data types and database types #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
referenced
this pull request
Mar 20, 2015
subnetmarco
changed the title
Introducing "represents" to fix the schema types problem
Fixing schema data types and database types
Mar 20, 2015
I decided to remove In the schema validation |
This pull request also fixes #81 |
subnetmarco
added a commit
that referenced
this pull request
Mar 20, 2015
Fixing schema data types and database types
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
Fixing schema data types and database types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this issue: bb12c81#commitcomment-10298943
I am not happy because it introduces one more property in the schemas. In the early days we tried to fix this with convention but it didn't work out well because of edge-cases, but maybe we can stil try going through that path.
To recap before we tried to fix this problem with convention and we tried to get everything that ended with
*id
and treat it as an UUID. This didn't always work well because some properties, likeaccounts.provider_id
, are not UUIDs but custom strings.So we decided to make
id
andtimestamp
data types, but they really arestring
andnumber
. We have three options here:id
is always going to bestring
andtimestamp
is always going to be anumber
.represents
or something like that.