-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/bin/kong global script #3
Comments
@ahmadnassri in #7 |
a classic init shell script can be run under upstart, systemd, etc. that's the probably the best way to approach this. this is how datadog agent does it. |
We have a good enough MVP script for now! |
@thibaultcha What happened with this? I can't seem to find any init scripts shipped with Kong. You said in #7 it was moved to this issue, so the trail seems to end here. |
This was about implementing a CLI, which we now have, not init scripts. For the record: so far we do not provide init scripts. |
What is the reasoning behind not offering init scripts? |
The community pressure for it is not huge so we currently allocate our - limited - resources on Kong itself. We would welcome such a contribution given it is provided for all our distribution packages - https://getkong.org/install/ |
Inheriting from BasePlugin is no longer needed and can cause performance drop. See #2
* fix issues with Kubernetes dns recursive SRV record * fix Kubernetes issue with SRV ports being '0' * updated for release 0.3.1
feat(azure-functions) update to new db & pdk
…both unset (#3) * fix(request-transformer) ensure REQUEST_TRANSFORMER_ADVANCED_LIMIT_BODY_SIZE is set if REQUEST_TRANSFORMER_ADVANCED_ENABLE_LIMIT_BODY is turned on * fix(request-transformer) add error log for invalid number, fix tests * fix(request-transformer) fix typo, add tests for error logs
### Summary Before this commit: ``` patching file LuaJIT-2.1-20190507/src/lj_tab.c patching file LuaJIT-2.1-20190507/src/lj_asm_arm.h patching file LuaJIT-2.1-20190507/src/lj_api.c patching file LuaJIT-2.1-20190507/src/lj_arch.h patching file LuaJIT-2.1-20190507/src/lj_cconv.c patching file LuaJIT-2.1-20190507/src/lj_obj.h patching file LuaJIT-2.1-20190507/src/lj_state.c patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/resty/core.lua patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/ngx/balancer.lua patching file lua-resty-websocket-0.07/lib/resty/websocket/client.lua patching file nginx-1.15.8/src/http/ngx_http_upstream.c Hunk #2 succeeded at 1691 (offset -3 lines). Hunk #4 succeeded at 1768 (offset -7 lines). patching file nginx-1.15.8/src/http/ngx_http_special_response.c patching file nginx-1.15.8/src/stream/ngx_stream_proxy_module.c Hunk #2 succeeded at 802 (offset 20 lines). patching file ngx_lua-0.10.15/src/ngx_http_lua_socket_tcp.c Hunk #5 succeeded at 1556 (offset 48 lines). Hunk #6 succeeded at 1626 (offset 48 lines). Hunk #7 succeeded at 1726 (offset 48 lines). Hunk #8 succeeded at 1749 (offset 48 lines). Hunk #9 succeeded at 1760 (offset 48 lines). Hunk #10 succeeded at 1775 (offset 48 lines). Hunk #11 succeeded at 1816 (offset 48 lines). Hunk #12 succeeded at 1827 (offset 48 lines). Hunk #13 succeeded at 1849 (offset 48 lines). Hunk #14 succeeded at 1868 (offset 48 lines). Hunk #15 succeeded at 1878 (offset 48 lines). Hunk #16 succeeded at 2008 (offset 48 lines). Hunk #17 succeeded at 6101 (offset 62 lines). patching file ngx_lua-0.10.15/src/ngx_http_lua_socket_tcp.h patching file ngx_lua-0.10.15/src/ngx_http_lua_socket_tcp.c Hunk #1 succeeded at 1647 (offset 48 lines). patching file ngx_lua-0.10.15/src/ngx_http_lua_socket_tcp.c Hunk #3 succeeded at 1579 (offset 48 lines). Hunk #4 succeeded at 1644 (offset 48 lines). Hunk #5 succeeded at 1668 (offset 48 lines). patching file ngx_lua-0.10.15/src/ngx_http_lua_socket_tcp.c Hunk #1 succeeded at 1756 (offset 48 lines). patching file ngx_lua-0.10.15/src/ngx_http_lua_balancer.c patching file ngx_lua-0.10.15/src/ngx_http_lua_common.h patching file ngx_lua-0.10.15/src/ngx_http_lua_module.c patching file ngx_lua-0.10.15/src/ngx_http_lua_string.c patching file ngx_stream_lua-0.0.7/src/ngx_stream_lua_control.c patching file ngx_stream_lua-0.0.7/src/ngx_stream_lua_variable.c patching file ngx_stream_lua-0.0.7/src/ngx_stream_lua_common.h patching file ngx_stream_lua-0.0.7/src/ngx_stream_lua_util.c patching file ngx_stream_lua-0.0.7/src/api/ngx_stream_lua_api.h ``` vs. (after this commit) ``` patching file LuaJIT-2.1-20190507/src/lj_tab.c patching file LuaJIT-2.1-20190507/src/lj_asm_arm.h patching file LuaJIT-2.1-20190507/src/lj_api.c patching file LuaJIT-2.1-20190507/src/lj_arch.h patching file LuaJIT-2.1-20190507/src/lj_cconv.c patching file LuaJIT-2.1-20190507/src/lj_obj.h patching file LuaJIT-2.1-20190507/src/lj_state.c patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/resty/core.lua patching file lua-resty-core-0.1.17/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.17/lib/ngx/balancer.lua patching file lua-resty-websocket-0.07/lib/resty/websocket/client.lua patching file nginx-1.15.8/src/http/ngx_http_upstream.c patching file nginx-1.15.8/src/http/ngx_http_special_response.c patching file nginx-1.15.8/src/stream/ngx_stream_proxy_module.c patching file ngx_lua-0.10.15/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.15/src/ngx_http_lua_socket_tcp.h patching file ngx_lua-0.10.15/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.15/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.15/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.15/src/ngx_http_lua_balancer.c patching file ngx_lua-0.10.15/src/ngx_http_lua_common.h patching file ngx_lua-0.10.15/src/ngx_http_lua_module.c patching file ngx_lua-0.10.15/src/ngx_http_lua_string.c patching file ngx_stream_lua-0.0.7/src/ngx_stream_lua_control.c patching file ngx_stream_lua-0.0.7/src/ngx_stream_lua_variable.c patching file ngx_stream_lua-0.0.7/src/ngx_stream_lua_common.h patching file ngx_stream_lua-0.0.7/src/ngx_stream_lua_util.c patching file ngx_stream_lua-0.0.7/src/api/ngx_stream_lua_api.h ```
) ### Summary ``` patching file LuaJIT-2.1-20200102/src/lj_api.c patching file LuaJIT-2.1-20200102/src/lj_arch.h Hunk #1 succeeded at 241 (offset 4 lines). patching file LuaJIT-2.1-20200102/src/lj_cconv.c patching file LuaJIT-2.1-20200102/src/lj_obj.h Hunk #1 succeeded at 831 (offset 1 line). patching file LuaJIT-2.1-20200102/src/lj_state.c patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/resty/core.lua Hunk #1 succeeded at 19 with fuzz 1 (offset -2 lines). patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/ngx/balancer.lua patching file lua-resty-core-0.1.19/lib/ngx/balancer.lua Hunk #1 succeeded at 45 (offset 7 lines). Hunk #2 succeeded at 348 (offset 137 lines). patching file lua-resty-core-0.1.19/lib/resty/core.lua patching file lua-resty-core-0.1.19/lib/resty/core/request.lua patching file lua-resty-core-0.1.19/lib/resty/core/utils.lua patching file lua-resty-websocket-0.07/lib/resty/websocket/client.lua patching file nginx-1.17.8/src/http/ngx_http_upstream.c Hunk #2 succeeded at 1688 (offset -3 lines). Hunk #3 succeeded at 1719 (offset -3 lines). Hunk #4 succeeded at 1765 (offset -3 lines). patching file nginx-1.17.8/src/http/ngx_http_special_response.c patching file nginx-1.17.8/src/stream/ngx_stream_proxy_module.c patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.h patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.17/src/ngx_http_lua_balancer.c patching file ngx_lua-0.10.17/src/ngx_http_lua_common.h patching file ngx_lua-0.10.17/src/ngx_http_lua_module.c patching file ngx_lua-0.10.17/src/ngx_http_lua_balancer.c patching file ngx_lua-0.10.17/src/ngx_http_lua_balancer.c patching file ngx_lua-0.10.17/src/ngx_http_lua_common.h patching file ngx_lua-0.10.17/src/ngx_http_lua_balancer.c patching file ngx_stream_lua-0.0.8/src/ngx_stream_lua_util.c Hunk #1 succeeded at 1965 with fuzz 2 (offset 10 lines). patching file ngx_stream_lua-0.0.8/src/api/ngx_stream_lua_api.h ``` vs. ``` patching file LuaJIT-2.1-20200102/src/lj_api.c patching file LuaJIT-2.1-20200102/src/lj_arch.h patching file LuaJIT-2.1-20200102/src/lj_cconv.c patching file LuaJIT-2.1-20200102/src/lj_obj.h patching file LuaJIT-2.1-20200102/src/lj_state.c patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/resty/core.lua patching file lua-resty-core-0.1.19/lib/resty/core/socket_tcp.lua patching file lua-resty-core-0.1.19/lib/ngx/balancer.lua patching file lua-resty-core-0.1.19/lib/ngx/balancer.lua patching file lua-resty-core-0.1.19/lib/resty/core.lua patching file lua-resty-core-0.1.19/lib/resty/core/request.lua patching file lua-resty-core-0.1.19/lib/resty/core/utils.lua patching file lua-resty-websocket-0.07/lib/resty/websocket/client.lua patching file nginx-1.17.8/src/http/ngx_http_upstream.c patching file nginx-1.17.8/src/http/ngx_http_special_response.c patching file nginx-1.17.8/src/stream/ngx_stream_proxy_module.c patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.h patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.17/src/ngx_http_lua_socket_tcp.c patching file ngx_lua-0.10.17/src/ngx_http_lua_balancer.c patching file ngx_lua-0.10.17/src/ngx_http_lua_common.h patching file ngx_lua-0.10.17/src/ngx_http_lua_module.c patching file ngx_lua-0.10.17/src/ngx_http_lua_balancer.c patching file ngx_lua-0.10.17/src/ngx_http_lua_balancer.c patching file ngx_lua-0.10.17/src/ngx_http_lua_common.h patching file ngx_lua-0.10.17/src/ngx_http_lua_balancer.c patching file ngx_stream_lua-0.0.8/src/ngx_stream_lua_util.c patching file ngx_stream_lua-0.0.8/src/api/ngx_stream_lua_api.h ```
This adds a check during `init` that will prevent Kong from starting if any filter chain entities are found in the database using a filter that is not installed. Example: > Error: ./kong/cmd/start.lua:99: nginx: [error] init_by_lua error: /path/to/kong/init.lua:750: [wasm]: found one or more filter chain entities with filters that are not enabled/installed: > filter chain: 9e0b56d6-0e8c-469f-bf15-142debdd5d05, filter: #1 (response_transformer) > filter chain: 9e0b56d6-0e8c-469f-bf15-142debdd5d05, filter: #3 (response_transformer) Previously, this condition would not be caught until the Wasm state is built during `init_worker`. This change brings Wasm more in line with the behavior of the plugins iterator.
This adds a check during `init` that will prevent Kong from starting if any filter chain entities are found in the database using a filter that is not installed. Example: > Error: ./kong/cmd/start.lua:99: nginx: [error] init_by_lua error: /path/to/kong/init.lua:750: [wasm]: found one or more filter chain entities with filters that are not enabled/installed: > filter chain: 9e0b56d6-0e8c-469f-bf15-142debdd5d05, filter: #1 (response_transformer) > filter chain: 9e0b56d6-0e8c-469f-bf15-142debdd5d05, filter: #3 (response_transformer) Previously, this condition would not be caught until the Wasm state is built during `init_worker`. This change brings Wasm more in line with the behavior of the plugins iterator.
This adds a check during `init` that will prevent Kong from starting if any filter chain entities are found in the database using a filter that is not installed. Example: > Error: ./kong/cmd/start.lua:99: nginx: [error] init_by_lua error: /path/to/kong/init.lua:750: [wasm]: found one or more filter chain entities with filters that are not enabled/installed: > filter chain: 9e0b56d6-0e8c-469f-bf15-142debdd5d05, filter: #1 (response_transformer) > filter chain: 9e0b56d6-0e8c-469f-bf15-142debdd5d05, filter: #3 (response_transformer) Previously, this condition would not be caught until the Wasm state is built during `init_worker`. This change brings Wasm more in line with the behavior of the plugins iterator.
This adds a check during `init` that will prevent Kong from starting if any filter chain entities are found in the database using a filter that is not installed. Example: > Error: ./kong/cmd/start.lua:99: nginx: [error] init_by_lua error: /path/to/kong/init.lua:750: [wasm]: found one or more filter chain entities with filters that are not enabled/installed: > filter chain: 9e0b56d6-0e8c-469f-bf15-142debdd5d05, filter: #1 (response_transformer) > filter chain: 9e0b56d6-0e8c-469f-bf15-142debdd5d05, filter: #3 (response_transformer) Previously, this condition would not be caught until the Wasm state is built during `init_worker`. This change brings Wasm more in line with the behavior of the plugins iterator. (cherry picked from commit 9a5353e)
The global script for Kong should invoke commands such as
migrate
,start
,stop
etc...We need to consider if we are going to write it in Lua or Bash. Lua will be installed on the machine anyways to run Kong and we could leverage tools already written such as migrate and seed.
The text was updated successfully, but these errors were encountered: