fix: prevent unparseable response cookie from causing request to fail [INS-4851] #8289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-willis
force-pushed
the
fix/prevent-unparseable-cookie-exception-INS-4851
branch
2 times, most recently
from
052b551 to
e26165e
Compare
jackkav
reviewed
Jan 13, 2025
ryan-willis
force-pushed
the
fix/prevent-unparseable-cookie-exception-INS-4851
branch
from
e26165e to
85360ca
Compare
ryan-willis
force-pushed
the
fix/prevent-unparseable-cookie-exception-INS-4851
branch
from
85360ca to
addb331
Compare
jackkav
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent malformed cookies from throwing application errors for otherwise successful requests, this PR changes to loose cookie parsing so that a set-cookie header sent as
"=value"will be transformed intokey: "", value: "value". We are choosing to retain RFC-compliant types so a missing key will be an empty string as opposed tonullorundefined.One caveat is: since the cookie is malformed, it will not be added to the cookie jar.