fix: prevent unparseable response cookie from causing request to fail

packages/insomnia-sdk/src/objects/__tests__/cookies.test.ts

@@ -64,6 +64,11 @@ describe('test Cookie object', () => {
         expect(
             Cookie.unparseSingle(cookie1Opt)
         ).toEqual(expectedCookieString);
+
+        const malformedCookieString = '=gingerale';
+        expect(
+            Cookie.parse(malformedCookieString)
+        ).toBeFalsy();
     });
 
     it('test cookie transforming', () => {

packages/insomnia-sdk/src/objects/cookies.ts

@@ -29,6 +29,7 @@ export interface CookieOptions extends InsomniaCookieExtensions {
 export class Cookie extends Property {
     override readonly _kind: string = 'Cookie';
     protected cookie: ToughCookie;
+    public isValid: boolean = true;
     private extensions?: { key: string; value: string }[];
     private insoExtensions: InsomniaCookieExtensions = {};
 
@@ -38,6 +39,7 @@ export class Cookie extends Property {
         if (typeof cookieDef === 'string') {
             const cookieDefParsed = Cookie.parse(cookieDef);
             if (!cookieDefParsed) {
+                this.isValid = false;
                 throw Error('failed to parse cookie, the cookie string seems invalid');
             }
             cookieDef = cookieDefParsed;
@@ -71,7 +73,8 @@ export class Cookie extends Property {
     static parse(cookieStr: string) {
         const cookieObj = ToughCookie.parse(cookieStr);
         if (!cookieObj) {
-            throw Error('failed to parse cookie, the cookie string seems invalid');
+            // throw Error('failed to parse cookie, the cookie string seems invalid');
+            return false;
         }
 
         const hostOnly = cookieObj.extensions?.includes('HostOnly') || false;

packages/insomnia-sdk/src/objects/response.ts

@@ -52,7 +52,7 @@ export class Response extends Property {
         this.body = options.body || '';
         this.code = options.code;
         this.cookies = new CookieList(
-            options.cookie?.map(cookie => new Cookie(cookie)) || [],
+            (options.cookie?.map(cookie => new Cookie(cookie)) || []).filter(cookie => cookie.isValid),
         );
         this.headers = new HeaderList(
             undefined,

packages/insomnia-sdk/src/objects/send-request.ts

@@ -243,7 +243,7 @@ async function curlOutputToResponse(
                 };
             }
 
-            return cookieObj;
+            return undefined;
         })
         .filter(cookieOpt => cookieOpt !== undefined);