Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Filter history): Error when filter is not a valid query selector #7040

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

gatzjames
Copy link
Contributor

Using the JSON path filter as keys can throw errors since it sometimes can be an invalid selector.

Highlights:

  • Updates the keys to be valid query selectors using the index
  • Updates the dropdown to use tailwind

Closes #6977

@gatzjames gatzjames requested a review from a team January 31, 2024 19:15
@gatzjames gatzjames self-assigned this Jan 31, 2024
@gatzjames gatzjames merged commit 1b52859 into Kong:release/8.6.1 Feb 2, 2024
3 of 4 checks passed
@gatzjames gatzjames deleted the fix/filter-history branch February 2, 2024 10:59
gatzjames added a commit that referenced this pull request Feb 6, 2024
* Bump app version to 8.6.1

* feat(unit-tests): Unit test reordering (#7020)

* re-orderable test suites

* re-orderable tests

* fix ts

* Use db methods for sorting

* sort suites and unit tests in inso

* fix suite rename

* Fixes #7011 (#7012)

* Fixes #7009 (#7010)

* chore: edit changelog process [INS-3456] (#7001)

* fix(workspace): Add default name for when creating a workspace (#7046)

* Add default name for when creating a design/collection

* workspace update and creation

* fix filter history keys not being valid selectors (#7040)

* remove invalid wide css prop (#7041)

* feat(environment): update environments icons (#7050)

* update environments icons

* fix workspace name

* fix one line editor being scrollable (#7059)

* change 8.0 to 8 (#7061)

* Cleanup page containers and add hint container in the page (#7060)

* feat(pane-tabs): Consistent styles for tabs (#7062)

* response/request pane tab counts

* tab dropdown colors

* fix updates to db leading to errors in loader fetchers (#7033)

* feat(command-palette): add button to open the command palette (#7064)

* add button for quick search

* update button styles in project

* make it look good with gh stars

* fix ts issue

* changelog

---------

Co-authored-by: Jack Kavanagh <3679927+jackkav@users.noreply.github.com>
Co-authored-by: James Gatz <jamesgatzos@gmail.com>
Co-authored-by: Jeroen Van den Berghe <vandenberghe.jeroen@gmail.com>
Co-authored-by: Filipe Freire <livrofubia@gmail.com>
jackkav added a commit to jackkav/insomnia that referenced this pull request Mar 13, 2024
* Bump app version to 8.6.1

* feat(unit-tests): Unit test reordering (Kong#7020)

* re-orderable test suites

* re-orderable tests

* fix ts

* Use db methods for sorting

* sort suites and unit tests in inso

* fix suite rename

* Fixes Kong#7011 (Kong#7012)

* Fixes Kong#7009 (Kong#7010)

* chore: edit changelog process [INS-3456] (Kong#7001)

* fix(workspace): Add default name for when creating a workspace (Kong#7046)

* Add default name for when creating a design/collection

* workspace update and creation

* fix filter history keys not being valid selectors (Kong#7040)

* remove invalid wide css prop (Kong#7041)

* feat(environment): update environments icons (Kong#7050)

* update environments icons

* fix workspace name

* fix one line editor being scrollable (Kong#7059)

* change 8.0 to 8 (Kong#7061)

* Cleanup page containers and add hint container in the page (Kong#7060)

* feat(pane-tabs): Consistent styles for tabs (Kong#7062)

* response/request pane tab counts

* tab dropdown colors

* fix updates to db leading to errors in loader fetchers (Kong#7033)

* feat(command-palette): add button to open the command palette (Kong#7064)

* add button for quick search

* update button styles in project

* make it look good with gh stars

* fix ts issue

* changelog

---------

Co-authored-by: Jack Kavanagh <3679927+jackkav@users.noreply.github.com>
Co-authored-by: James Gatz <jamesgatzos@gmail.com>
Co-authored-by: Jeroen Van den Berghe <vandenberghe.jeroen@gmail.com>
Co-authored-by: Filipe Freire <livrofubia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants